Skip to content

OSDOCS-4744: 4.9 changes #55598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Feb 28, 2023
Merged

OSDOCS-4744: 4.9 changes #55598

mburke5678 merged 1 commit into from
Feb 28, 2023

Conversation

@skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented Feb 6, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.9 PR of #55448

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2023
@skopacz1 skopacz1 mentioned this pull request Feb 6, 2023
Merged
1 task
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.9 PR of #55448

Preview: http://file.bos.redhat.com/skopacz/4744_4.9/updating/updating-restricted-network-cluster/mirroring_image_repository.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.9 PR of #55448

Current/live documentation:
https://docs.openshift.com/container-platform/4.9/updating/updating-restricted-network-cluster/restricted-network-update-osus.html#update-service-mirror-release_updating-restricted-network-cluster-osus
and
https://docs.openshift.com/container-platform/4.9/updating/updating-restricted-network-cluster/restricted-network-update.html#updating-restricted-network-mirror-host

Preview: http://file.bos.redhat.com/skopacz/4744_4.9/updating/updating-restricted-network-cluster/mirroring_image_repository.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skopacz1 skopacz1 force-pushed the 4744_4.9 branch 3 times, most recently from 3e50b33 to c80a347 Compare February 9, 2023 18:24
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.9 PR of #55448

Current/live documentation:
https://docs.openshift.com/container-platform/4.9/updating/updating-restricted-network-cluster/restricted-network-update-osus.html#update-service-mirror-release_updating-restricted-network-cluster-osus
and
https://docs.openshift.com/container-platform/4.9/updating/updating-restricted-network-cluster/restricted-network-update.html#updating-restricted-network-mirror-host

Preview: http://file.bos.redhat.com/skopacz/4744_4.9/updating/updating-restricted-network-cluster/mirroring-image-repository.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skopacz1
Copy link
Contributor Author

skopacz1 commented Feb 22, 2023

@shellyyang1989 PTAL

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@shellyyang1989
Copy link

shellyyang1989 commented Feb 23, 2023

Generally looks good to me. Just wonder why we don't recommend oc-mirror to 4.9 users?

@shellyyang1989
Copy link

shellyyang1989 commented Feb 23, 2023

Generally looks good to me. Just wonder why we don't recommend oc-mirror to 4.9 users?

ah, 4.10 introduces the oc-mirror OpenShift CLI (oc) plugin as a Technology Preview.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023
@skopacz1
Copy link
Contributor Author

skopacz1 commented Feb 27, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 27, 2023
@mburke5678
Copy link
Contributor

mburke5678 commented Feb 27, 2023

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@mburke5678 mburke5678 added this to the Continuous Release milestone Feb 27, 2023
@skopacz1
Copy link
Contributor Author

skopacz1 commented Feb 28, 2023

@mburke5678 I think you added a branch label for 3.9, not 4.9

@skopacz1
Copy link
Contributor Author

skopacz1 commented Feb 28, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2023
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 28, 2023
@mburke5678 mburke5678 merged commit 0b92b87 into openshift:enterprise-4.9 Feb 28, 2023
@skopacz1 skopacz1 deleted the 4744_4.9 branch October 31, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mburke5678 mburke5678

Labels

branch/enterprise-4.9 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@skopacz1 @openshift-ci-robot @shellyyang1989 @mburke5678 @openshift-merge-robot