Skip to content

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2023

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.10 PR of #55448

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2023

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.10 PR of #55448

Preview: http://file.bos.redhat.com/skopacz/4744_4.10/updating/updating-restricted-network-cluster/mirroring_image_repository.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023

@skopacz1 skopacz1 force-pushed the 4744_4.10 branch 3 times, most recently from dc4100e to 32cdaca Compare February 9, 2023 17:44
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023

@skopacz1
Copy link
Contributor Author

@shellyyang1989 PTAL

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@shellyyang1989
Copy link

@skopacz1 generally looks good to me. Just wonder why we don't recommend oc-mirror to 4.10 users?

@shellyyang1989
Copy link

@skopacz1 generally looks good to me. Just wonder why we don't recommend oc-mirror to 4.10 users?

ah, 4.10 introduces the oc-mirror OpenShift CLI (oc) plugin as a Technology Preview.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023
@skopacz1
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 27, 2023
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 27, 2023
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@skopacz1
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2023
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 28, 2023
@mburke5678 mburke5678 merged commit f175aef into openshift:enterprise-4.10 Feb 28, 2023
@mburke5678 mburke5678 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 28, 2023
@skopacz1 skopacz1 deleted the 4744_4.10 branch October 31, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants