Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _topic_maps/_topic_map.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1551,6 +1551,8 @@ Topics:
File: persistent-storage-csi-google-cloud-file
- Name: IBM VPC Block CSI Driver Operator
File: persistent-storage-csi-ibm-vpc-block
- Name: IBM Power Virtual Server Block CSI Driver Operator
File: persistent-storage-csi-ibm-powervs-block
- Name: OpenStack Cinder CSI Driver Operator
File: persistent-storage-csi-cinder
- Name: OpenStack Manila CSI Driver Operator
Expand Down
1 change: 1 addition & 0 deletions modules/persistent-storage-csi-drivers-supported.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ifndef::openshift-rosa[]
|GCP Filestore | ✅ | - | ✅| -
endif::openshift-rosa[]
ifndef::openshift-dedicated,openshift-rosa[]
|{ibmpowerProductName} Virtual Server Block | - | - | ✅
|IBM VPC Block | ✅^[3]^ | - | ✅^[3]^| -
|Microsoft Azure Disk | ✅ | ✅ | ✅| -
|Microsoft Azure Stack Hub | ✅ | ✅ | ✅| -
Expand Down

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation follows the same format as every other csi driver operator in the OpenShift docs.
Ref: https://docs.openshift.com/container-platform/4.8/storage/container_storage_interface/persistent-storage-csi-gcp-pd.html

Do we need to put additional introduction info?

@Madhan-SWE Madhan-SWE Apr 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwelldb maxwelldb Apr 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhan-SWE I'd say that those docs should also follow the format in our guidelines. Can't explain why they don't. There could be an exception for these assemblies, but I don't have a great way to find that out.

e: I'm not on a review squad this week, so I'm sure someone will pick this up shortly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwelldb thanks for the update.

@kelbrown20 @maxwelldb could you please point us to the right person who can take a look at above. Thanks.
cc : @jaypoulz

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sferich888, since these are all within the openshift org, are you ok with them? Or are there specific requirements you'd like to be confirmed first?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not link to GitHub no matter where the content is.

If we are providing a link for a purpose then the content of that link should be documented in our docs.

Most of these looks like references (to whit I have to ask the value of the reference), shot of providing a breadcrumb trail.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new content (without GitHub links).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelbrown20 @kalexand-rh could you please review the PR content ? Thanks.

Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
:_content-type: ASSEMBLY
[id="persistent-storage-csi-ibm-powervs-block"]
= {ibmpowerProductName} Virtual Server Block CSI Driver Operator
include::_attributes/common-attributes.adoc[]
:context: persistent-storage-csi-ibm-powervs-block

toc::[]

[id="persistent-storage-csi-ibm-powervs-block-introduction_{context}"]
== Introduction

The IBM Power Virtual Server Block CSI Driver will be installed through IBM Power Virtual Server Block CSI Driver Operator and the operator is based on libarary-go. The OpenShift library-go is a collection of functions that allow us to build OpenShift operators easily. Most of the functionality of a CSI driver operator is already available there. The IBM Power Virtual Server Block CSI Driver Operator is installed by the cluster-storage-operator. The Cluster-storage-operator installs the IBM Power Virtual Server Block CSI Driver Operator if the Platform type is Power Virtual Servers.

[id="persistent-storage-csi-ibm-powervs-block-overview_{context}"]
== Overview

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an [id=] block before Overview.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an [id=] block before Overview.


{product-title} can provision persistent volumes (PVs) by using the Container Storage Interface (CSI) driver for {ibmpowerProductName} Virtual Server Block Storage.

Comment thread
alishaIBM marked this conversation as resolved.
Outdated
:FeatureName: {ibmpowerProductName} Virtual Server Block CSI Driver Operator
include::snippets/technology-preview.adoc[leveloffset=+1]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Technology Preview Note. FYI : @manojnkumar @Madhan-SWE @kelbrown20


Familiarity with xref:../../storage/understanding-persistent-storage.adoc#understanding-persistent-storage[persistent storage] and xref:../../storage/container_storage_interface/persistent-storage-csi.adoc#persistent-storage-csi[configuring CSI volumes] is helpful when working with a CSI Operator and driver.

To create CSI-provisioned PVs that mount to {ibmpowerProductName} Virtual Server Block storage assets, {product-title} installs the {ibmpowerProductName} Virtual Server Block CSI Driver Operator and the {ibmpowerProductName} Virtual Server Block CSI driver by default in the `openshift-cluster-csi-drivers` namespace.

* The _{ibmpowerProductName} Virtual Server Block CSI Driver Operator_ provides two storage classes named `ibm-powervs-tier1` (default), and `ibm-powervs-tier3` for different tiers that you can use to create persistent volume claims (PVCs). The {ibmpowerProductName} Virtual Server Block CSI Driver Operator supports dynamic volume provisioning by allowing storage volumes to be created on demand, eliminating the need for cluster administrators to pre-provision storage.
Comment thread
alishaIBM marked this conversation as resolved.
Outdated

* The _{ibmpowerProductName} Virtual Server Block CSI driver_ allows you to create and mount {ibmpowerProductName} Virtual Server Block PVs.

include::modules/persistent-storage-csi-about.adoc[leveloffset=+1]

[role="_additional-resources"]
.Additional resources
* xref:../../storage/container_storage_interface/persistent-storage-csi.adoc#persistent-storage-csi[Configuring CSI volumes]