CNV-17539: Document default storage provider for CNV+SNO #49607

bgaydosrh · 2022-08-25T15:50:16Z

For 4.12 only.

Jira: https://issues.redhat.com/browse/CNV-17539

Direct doc preview link: https://49607--docspreview.netlify.app/openshift-enterprise/latest/virt/about-virt.html

Tagging Alex Kalenyuk for Code Review in Jira.
Tagging Jenia Peimer for QE Review. in Jira.

akalenyu

I think we should bring up assisted-installer here, would that be reasonable?
Just because the main focus of the epic was that
The assisted installer is now providing a new out-of-the-box storage solution.

Up until 4.11, selecting CNV on SNO meant that we also auto deploy the hostpath provisioner storage solution. Now with 4.12, we have LVMO instead (you could still use HPP).

More info can be found here:
https://issues.redhat.com/browse/CNV-17537?focusedCommentId=20783231&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-20783231

modules/virt-snocaps-differences.adoc

ocpdocs-previewbot · 2022-09-21T22:16:24Z

🤖 Updated build preview is available at:
https://49607--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2673

bgaydosrh · 2022-09-29T19:03:01Z

@akalenyu - This PR should be ready for final review. See the Jira link above for more details. Thanks.

akalenyu

Thank you! I think we are really close to getting the point across

modules/virt-snocaps-differences.adoc

bgaydosrh · 2022-10-11T19:52:32Z

Thank you! I think we are really close to getting the point across

Thanks @akalenyu - let me know what you think of this version and we can send it to QE.

akalenyu · 2022-10-19T10:42:23Z

Thank you! I think we are really close to getting the point across

Thanks @akalenyu - let me know what you think of this version and we can send it to QE.

/lgtm
Thank you!

openshift-ci · 2022-10-19T10:42:56Z

@akalenyu: changing LGTM is restricted to collaborators

Details

In response to this:

Thank you! I think we are really close to getting the point across

Thanks @akalenyu - let me know what you think of this version and we can send it to QE.

/lgtm
Thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bgaydosrh · 2022-10-19T22:23:34Z

Just FYI @akalenyu - This is transparent to you but I moved the content into the assembly, rather than the module file, as we can't have xrefs in our modules due to an internal limitation. Thanks @ousleyp for catching this......

I will wait for Jenia to QE this. If she can't get to it within the week, I'll see about getting another resource.

Thanks
Bob

jpeimer · 2022-10-23T09:42:56Z

/lgtm
Thanks @bgaydosrh and @akalenyu!

bergerhoffer

A few suggestions!

virt/about-virt.adoc

openshift-ci · 2022-10-26T20:13:48Z

New changes are detected. LGTM label has been removed.

bgaydosrh · 2022-10-26T20:21:27Z

@akalenyu - Peer review is complete. I only have one question for you. We cannot use "out-of-the-box" according to our style guidelines, mostly due to translation issues (it's kind of industry slang). Can we say "preconfigured" instead, as in:

"When provisioning with the assisted installer, preconfigured persistent storage is automatically deployed".

akalenyu · 2022-10-27T08:38:35Z

@akalenyu - Peer review is complete. I only have one question for you. We cannot use "out-of-the-box" according to our style guidelines, mostly due to translation issues (it's kind of industry slang). Can we say "preconfigured" instead, as in:

"When provisioning with the assisted installer, preconfigured persistent storage is automatically deployed".

Definitely can. thank you

bergerhoffer

Just a few last things to fix!

bergerhoffer · 2022-10-27T20:25:02Z

modules/virt-sno-differences.adoc

This now repeats as "Single-node OpenShift OpenShift Container Platform differences". I think you should remove the {product-title} now

Done, thanks.

bergerhoffer · 2022-10-27T20:28:09Z

modules/virt-sno-differences.adoc

This now renders as "OpenShift Container Platform Data Foundation Logical Volume Manager Operator", which isn't correct. This one of those cases where it's fine to hard code "OpenShift" because it's part of the Operator name: "OpenShift Data Foundation Logical Volume Manager Operator"

Gotcha, thanks.

bergerhoffer · 2022-10-27T20:29:00Z

modules/virt-sno-differences.adoc

Moving module content to assembly

bgaydosrh · 2022-10-31T17:43:07Z

@bergerhoffer - This should be ready for merge/review. Thanks!

bergerhoffer

LGTM for merging!

bergerhoffer · 2022-10-31T18:02:25Z

/cherrypick enterprise-4.12

openshift-cherrypick-robot · 2022-10-31T18:03:56Z

@bergerhoffer: new pull request created: #52325

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2022

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 68bd380 to aee748d Compare August 25, 2022 16:39

akalenyu reviewed Sep 1, 2022

View reviewed changes

modules/virt-snocaps-differences.adoc Outdated Show resolved Hide resolved

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 80e9ae0 to b53cd36 Compare September 8, 2022 20:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2022

bgaydosrh force-pushed the CNV-17539 branch from b53cd36 to 5e71311 Compare September 21, 2022 22:09

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2022

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 08253d6 to cdf11b0 Compare September 29, 2022 19:02

akalenyu reviewed Oct 2, 2022

View reviewed changes

modules/virt-snocaps-differences.adoc Outdated Show resolved Hide resolved

modules/virt-snocaps-differences.adoc Outdated Show resolved Hide resolved

modules/virt-snocaps-differences.adoc Outdated Show resolved Hide resolved

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 86f4423 to 6fd0f85 Compare October 11, 2022 19:52

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 240ba52 to c82882f Compare October 19, 2022 22:19

openshift-ci bot assigned jpeimer Oct 23, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2022

bergerhoffer reviewed Oct 25, 2022

View reviewed changes

bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR CNV Label for all CNV PRs branch/enterprise-4.12 labels Oct 25, 2022

bgaydosrh force-pushed the CNV-17539 branch from c82882f to 816e83d Compare October 26, 2022 20:13

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022

bgaydosrh force-pushed the CNV-17539 branch from 816e83d to d618a87 Compare October 26, 2022 20:14

bgaydosrh force-pushed the CNV-17539 branch from 908c1a9 to cef1d83 Compare October 26, 2022 20:38

bergerhoffer reviewed Oct 27, 2022

View reviewed changes

bgaydosrh force-pushed the CNV-17539 branch 2 times, most recently from 6e6b281 to 852c196 Compare October 27, 2022 23:35

CNV-17539: Document default storage provider for CNV+SNO

852c196

Moving module content to assembly

bergerhoffer reviewed Oct 31, 2022

View reviewed changes

bergerhoffer merged commit 2573411 into openshift:main Oct 31, 2022

openshift-cherrypick-robot mentioned this pull request Oct 31, 2022

[enterprise-4.12] CNV-17539: Document default storage provider for CNV+SNO #52325

Merged

CNV-17539: Document default storage provider for CNV+SNO #49607

CNV-17539: Document default storage provider for CNV+SNO #49607

Uh oh!

Conversation

bgaydosrh commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akalenyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ocpdocs-previewbot commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgaydosrh commented Sep 29, 2022

Uh oh!

akalenyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgaydosrh commented Oct 11, 2022

Uh oh!

akalenyu commented Oct 19, 2022

Uh oh!

openshift-ci bot commented Oct 19, 2022

Uh oh!

bgaydosrh commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpeimer commented Oct 23, 2022

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Oct 26, 2022

Uh oh!

bgaydosrh commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akalenyu commented Oct 27, 2022

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

bgaydosrh commented Oct 31, 2022

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

bergerhoffer commented Oct 31, 2022

Uh oh!

openshift-cherrypick-robot commented Oct 31, 2022

Uh oh!

Reviewers

bgaydosrh commented Aug 25, 2022 •

edited

Loading

ocpdocs-previewbot commented Sep 21, 2022 •

edited

Loading

bgaydosrh commented Oct 19, 2022 •

edited

Loading

bgaydosrh commented Oct 26, 2022 •

edited

Loading