Added incremental buildConfig #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This fixes #424. |
dev_guide/builds.adoc
Outdated
Contributor
There was a problem hiding this comment.
we should be able to avoid quoting the whole buildconfig again, since @mfojtik is adding a buildconfig example in this very same file.
Author
Author
There was a problem hiding this comment.
I was thinking of my paragraph as being the continuation of the previous one, where buildConfig is used.
Contributor
|
@soltysh 2 nits and lgtm. |
Author
|
2nits addressed, one commented. |
Contributor
|
looks good to me, @adellape merge at will. |
dev_guide/builds.adoc
Outdated
Contributor
There was a problem hiding this comment.
<1> should be outside the ".
Author
|
@adellape addressed your comments. |
Contributor
|
@soltysh Thanks, LGTM. Will merge after build passes. |
adellape
added a commit
that referenced
this pull request
Jun 10, 2015
Added incremental buildConfig
prakashmishra1598
added a commit
to prakashmishra1598/openshift-docs
that referenced
this pull request
Dec 13, 2016
…t#192 openshift#211 openshift#240 openshift#281 openshift#313 openshift#465 Updated index-commercial, fixed cross calling and faulty links on lines openshift#37 openshift#42 openshift#99 openshift#192 openshift#211 openshift#240 openshift#281 openshift#313 openshift#465
ahardin-rh
added a commit
that referenced
this pull request
Dec 15, 2016
sbeskin-redhat
pushed a commit
to sbeskin-redhat/openshift-docs
that referenced
this pull request
Oct 24, 2022
Folder reorganization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR waits for #444 being merged first. I'll rebase on top of it.
@danmcp @bparees ptal in the meantime