Skip to content

SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines #44552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abrennan89 merged 1 commit into from
Apr 20, 2022
Merged

SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines #44552

abrennan89 merged 1 commit into from
Apr 20, 2022

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Apr 13, 2022 •
edited
Loading

@abrennan89 abrennan89 added this to the Next Release milestone Apr 13, 2022
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 13, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 7b01869
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62602e0de5b41e00084a18cd
😎 Deploy Preview https://deploy-preview-44552--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@abrennan89 abrennan89 force-pushed the kafkaAbstracts branch 2 times, most recently from e3381a9 to 89896c6 Compare April 14, 2022 15:56
@abrennan89 abrennan89 changed the title [WIP] SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines Apr 14, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2022
matzew
matzew reviewed Apr 19, 2022
View reviewed changes
matzew
matzew reviewed Apr 19, 2022
View reviewed changes
matzew
matzew reviewed Apr 19, 2022
View reviewed changes
modules/serverless-install-kafka-odc.adoc Outdated
Copy link
Member

@matzew matzew Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, to use the Kafka channel, broker or sink, you must specify the bootstrap servers.

For the broker: the "bootstrap" server can be overriden, with a ConfigMap that is in the "user namespace", and the broker referencing to that one (my original PR for the kafka broker doc had text for using the default global config, and a custom (or overriden) config/broker.

For the kafka sink, the bootstrap URL is only needed on that CR file - not on Knative Kafka

Copy link
Contributor Author

@abrennan89 abrennan89 Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew can you open a follow up Jira for this please, it's out of scope for this PR which is just intended to get our docs in line with Jupiter requirements. This is previously existing content that was just moved slightly in this PR.

jrangelramos
jrangelramos reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jrangelramos jrangelramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE Approved

tmalove
tmalove reviewed Apr 19, 2022
View reviewed changes
michaelryanpeter
michaelryanpeter reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tami's comment regarding a serial comma. Otherwise, I left a minimalism suggestion regarding the sentence about the declarative API.

Otherwise, LGTM!

(And a friendly reminder to squash your commits once your edits are made) :)

@michaelryanpeter michaelryanpeter added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 19, 2022
@abrennan89 abrennan89 merged commit 9eec0d4 into openshift:main Apr 20, 2022
@abrennan89
Copy link
Contributor Author

abrennan89 commented Apr 20, 2022

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor Author

abrennan89 commented Apr 20, 2022

/cherrypick enterprise-4.10

@abrennan89
Copy link
Contributor Author

abrennan89 commented Apr 20, 2022

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 20, 2022

@abrennan89: new pull request created: #44759

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 20, 2022

@abrennan89: new pull request created: #44760

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 20, 2022

@abrennan89: new pull request created: #44761

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 20, 2022
Merged
Merged
Merged
@abrennan89 abrennan89 deleted the kafkaAbstracts branch June 30, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

+3 more reviewers

@matzew matzew matzew left review comments

@jrangelramos jrangelramos jrangelramos left review comments

@tmalove tmalove tmalove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@abrennan89 @openshift-cherrypick-robot @matzew @jrangelramos @michaelryanpeter @tmalove