Skip to content

Conversation

@sayjadha
Copy link
Contributor

@sayjadha sayjadha commented Apr 13, 2022

This PR is to address the JIRA issue: https://issues.redhat.com/browse/OSDOCS-3173

Updated topic:
https://deploy-preview-44546--osdocs.netlify.app/openshift-rosa/latest/rosa_planning/rosa-aws-prereqs#osd-aws-privatelink-firewall-prerequisites

Following are the updates:

  1. Added a row to the second table in step 3 at the AWS PrivateLink firewall prerequisites containing:
    URL: servicequotas..amazonaws.com
    Function: Required. Used to confirm quotas for deploying the service.
    Port: 443, 80

  2. Added another row to the same table containing:
    URL: tagging..amazonaws.com
    Function: Allows the assignment of metadata about AWS resources in the form of tags.
    Port: 443, 80

  3. Renamed the title here from "AWS PrivateLink firewall prerequisites" to "AWS firewall prerequisites".

  4. Added a note stating that the table in step 1 on that page stating that "Creating a firewall with a ROSA private cluster (non-PrivateLink) is not supported."

Repo: Request cherrypick to enterprise-4.10 and enterprise-4.11

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 2ace997
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/6272c316329ec60007260e9c
😎 Deploy Preview https://deploy-preview-44546--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xueli181114
Copy link

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh ahardin-rh added this to the Next Release milestone Apr 19, 2022
@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 19, 2022
@ahardin-rh
Copy link
Contributor

Just one comment from me. Thanks!

@sayjadha sayjadha force-pushed the JIRA-OSDOCS3173 branch from 5c19085 to 2ace997 Compare May 4, 2022 18:16
@sayjadha
Copy link
Contributor Author

sayjadha commented May 4, 2022

Hi peer review squad, I incorporated @ahardin-rh's feedback but for some reason the Travis build didn't run after I committed the changes. Could you please verify the change and merge the PR? Thank you.

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@bergerhoffer bergerhoffer merged commit 3b5c9df into openshift:main May 4, 2022
@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.11

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #45329

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #45330

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants