Merged
Conversation
openshift-ci
bot
added
the
size/S
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
/lgtm |
|
/lgtm |
bobfuru
reviewed
Apr 14, 2022
Contributor
There was a problem hiding this comment.
+1 I thought ISG had guidance for this but couldn't find the citation. 😀
Contributor
|
This is the new preview link: https://deploy-preview-44435--osdocs.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html |
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
@bobfuru ptal |
Contributor
|
LGTM, thanks! |
Contributor
|
/cherrypick enterprise-4.11 |
|
@bobfuru: new pull request created: #44611 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE
This PR is duplicated from #43576 but covers only the first file (modules/nw-ingress-controller-configuration-parameters.adoc) . Incorporated SME/peer review feedback.
@sherine-k @quarterpin
UPDATE
The rest_api.adoc file will be updated nearing the time of 4.11 release, as it's going to be built , based on the OpenAPI spec, which OpenShift derives from the openshift/api repository contents.