-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BZ2051452: Add L2 subnet info to vSphere, RHV, and Openstack prerequisites #43599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
50f0ef2 to
34c6282
Compare
c7daaef to
f47e270
Compare
|
Hi @cybertron, made changes to the PR as you adviced. Could you please take a look at this new one and see everything looks fine? It's basically one file with a sentence and a link. The other files are the IPI sections including this sentence. Thank you! |
cybertron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought I had already looked at this. A couple of thoughts inline.
|
Looks great! LGTM |
|
/lgtm |
|
/lgtm Thanks! |
|
@zhaozhanqi Hi! When you can, please let me know if you approve this PR so that we can merge it. Thanks! |
|
the update looks good to me for vsphere part. I checked that all IPI installation on VMC docs (under "Installing on VMC") are not applied the update. Those docs also need to be updated. Another question is that can we add KCS link directly in official doc? |
Hi! Thank you for checking this -- I'll add the note to those sections as well. About the link, yeah, this is not the first link to the knowledge base in the docset, so that should be ok :) |
|
New changes are detected. LGTM label has been removed. |
|
@cherraz thanks for updating. The changes look good to me now for vsphere part. |
|
Waiting for RHV and Openstack QEs to comment or give lgtm. |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note looks good to me, however shouldn't we include it in UPI installation method as well? It also seems to me it's missing from a couple of OpenStack doc (SR-IOV and OVS-DPDK).
|
This isn't relevant for UPI because it doesn't run keepalived. It also isn't necessary going forward because we switched everyone to unicast keepalived so it won't conflict. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added a reusable snippet across some vSphere, RHV, and Openstack installer IPI
FIXES BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2051452
PREVIEW:
Openstack
RHV
vSphere
vSphere cloud
VERSIONS: 4.10, 4.9, 4.8, 4.7, 4.6 (it doesn't apply to main)