Skip to content

Conversation

@Srivaralakshmi
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi commented Feb 21, 2022

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2022
@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 29fe00f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6214f7ace8279f000880714f

😎 Browse the preview: https://deploy-preview-42134--osdocs.netlify.app

@Srivaralakshmi
Copy link
Contributor Author

@pmacik, @dperaza4dustbit, @baijum, and @jc-berger: PTAL at the PR and provide your feedback. Thanks!

Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dperaza4dustbit
Copy link

/assign @pmacik

Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2022

@jc-berger: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Srivaralakshmi
Copy link
Contributor Author

Hi @jc-berger: Thanks for the suggestions. I have addressed them. PTAL and provide your LGTM.

@Srivaralakshmi
Copy link
Contributor Author

Hi, @pmacik Can you PTAL and provide your approval? Thanks!

@pmacik
Copy link
Contributor

pmacik commented Feb 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2022

@jc-berger: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixed peer review comments
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2022

New changes are detected. LGTM label has been removed.

@JStickler JStickler added branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Feb 22, 2022
@JStickler JStickler merged commit 87fbe5f into openshift:main Feb 22, 2022
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.9

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@JStickler: new pull request created: #42204

Details

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #42205

Details

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot

@JStickler: cannot checkout enterprise-4.11: error checking out enterprise-4.11: exit status 1. output: error: pathspec 'enterprise-4.11' did not match any file(s) known to git

Details

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Srivaralakshmi added a commit to Srivaralakshmi/openshift-docs that referenced this pull request Feb 24, 2022
Preeticp added a commit that referenced this pull request Feb 28, 2022
Revert Merge pull request #42134 from Srivaralakshmi/SBO-RN-1.0.1
aireilly pushed a commit to aireilly/openshift-docs that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants