RHEVDOCS3492, 3761: Aligned SBO 1.0.1 changes for IBM Z and Power #42121

SNiemann15 · 2022-02-18T14:45:27Z

OCP version for cherry-picking: enterprise-4.9, enterprise-4.10
JIRA issues: RHDEVDOCS-3492, RHDEVDOCS-3761
Google doc: https://docs.google.com/document/d/1BtPM-JliJFY7EwnhbDEXu1bofmtp1OvTz4TXzMLjGds/edit
Related PR for x86: SBO 1.0.1 Release updates #42505
Preview pages: https://deploy-preview-42121--osdocs.netlify.app/openshift-enterprise/latest/applications/connecting_applications_to_services/getting-started-with-service-binding-ibm-power-ibm-z.html
QE review:
- IBM Z - Johanna Husta
- IBM Power - Pravin D'silva

netlify · 2022-02-18T14:48:05Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 757b305

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621ce88bf788c50007f38ca9

😎 Browse the preview: https://deploy-preview-42121--osdocs.netlify.app

pravin-dsilva · 2022-02-18T18:51:24Z

modules/sbo-creating-a-postgresql-database-instance-power-z.adoc

Need this to populate the DB with the sample data.

with the new app, there is no need for populating the DB with the sample data, the application should initialize the DB o its own.

johusta · 2022-02-18T19:00:22Z

Under Deploying a PostgreSQL Operator - you cannot use oc apply -n my-petclinic -f - << EOD you have to use oc apply -f - << EOD being the installs in this yaml happen in different namespaces. You will want to decide if you want to be consistent for the rest of the steps or specify the -n my-petclinic to be consistent with x86.
Creating a PostgreSQL database - so we cannot use the same format at x86. the postgresql crunchy operator they use has SBO support built in. We have to put the SBO information as annotations in the metadata section of the postgresql deployment to allow us to use our postgresql operator to work with SBO. I can send you my working yaml or use the old yaml.
Deploying the spring pet clinic app. I tried to use what is specified but I get the following during creation as it relates to the section Service Stanza.

deployment.apps/spring-petclinic created error: error parsing STDIN: error converting YAML to JSON: yaml: line 5: did not find expected key

I will send you the correct format plus protocol needs to be TCP. I cannot get it format properly here.

This is the example output after the app creation

NAME                                READY   STATUS             RESTARTS        AGE
sampledatabase-9688b5f6d-565fr      1/1     Running            0               47m
spring-petclinic-594df7977b-khpms   0/1     CrashLoopBackOff   13 (104s ago)   44m

I was able to create the Service Binding however the springpet clinic app continues to fail with the following error:

Caused by: org.springframework.jdbc.datasource.init.ScriptStatementFailedException: Failed to execute SQL script statement #1 of URL [jar:file:/tmp/petclinic.jar!/BOOT-INF/classes!/db/postgres/schema.sql]: CREATE TABLE IF NOT EXISTS vets ( id INT GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY, first_name TEXT, last_name TEXT ); nested exception is org.postgresql.util.PSQLException: ERROR: syntax error at or near "GENERATED"
  Position: 42

So new app is not working for me.

Srivaralakshmi · 2022-02-21T11:43:14Z

@SNiemann15: PTAL at this comment in my PR. I prefer us to maintain consistency in our QSG content and writing style. Hence sending my pov for your consideration. Please let me know WDYT. Thanks!

Srivaralakshmi · 2022-02-21T12:01:46Z

@SNiemann15 Just a small observation. The QSG for x86 does not contain this prerequisite anymore: "You have installed PostgreSQL psql CLI." I did mention it in the list of changes over slack explicitly (the 1st one in the list). PTAL and do the needful for the SBO QSG for IBM Z and Power.

pmacik · 2022-02-21T12:20:01Z

modules/sbo-deploying-the-spring-petclinic-sample-application-power-z.adoc

Suggested change

labels:

app: spring-petclinic

name: spring-petclinic

labels:

app: spring-petclinic

name: spring-petclinic

you have a bad indentation here

SNiemann15 · 2022-02-21T12:35:10Z

@SNiemann15 Just a small observation. The QSG for x86 does not contain this prerequisite anymore: "You have installed PostgreSQL psql CLI." I did mention it in the list of changes over slack explicitly (the 1st one in the list). PTAL and do the needful for the SBO QSG for IBM Z and Power.

@Srivaralakshmi I know I left it there for the moment because @johusta wanted to verify if the prereq is still needed for P/Z or not. Once I get confirmation that it's not needed anymore I will remove.

pmacik · 2022-02-21T13:16:44Z

@johusta Looks like the dev4dev postgresql uses a different dialect for SQL, let me try to fix it - once I do, I'll re-push the updated image to the same URI quay.io/service-binding/spring-petclinic:latest so it should not affect the content of the docs

pmacik · 2022-02-21T13:23:20Z

modules/sbo-creating-a-postgresql-database-instance-power-z.adoc

this should not change - that introduces a wrong indentation and the apply fails

pmacik · 2022-02-21T13:54:55Z

@johusta Looks the old PG image version (9.6) might be the problem with the new app. Could you you try to update the DB image (https://github.com/openshift/openshift-docs/pull/42121/files#diff-807b32351555f711f63cdde21d3ef6702d04bed8c5af4b9f1b79f703129828b5R30) from registry.redhat.io/rhel8/postgresql-96:latest (which is deprecated anyway ) to registry.redhat.io/rhel8/postgresql-13:latest ?

johusta · 2022-02-21T23:00:43Z

Step 4. Setup port forwarding...... in the port forward string change spring-petclinic-rest to spring-petclinic

pravin-dsilva · 2022-02-24T13:34:29Z

modules/sbo-connecting-spring-petclinic-sample-app-to-postgresql-database-service-power-z.adoc

the correct version v1alpha1 is already specified so version: v1beta1 should be removed.

Suggested change

- group: postgresql.dev4devs.com

version: v1beta1

kind: Database <2>

name: sampledatabase

version: v1alpha1

- group: postgresql.dev4devs.com

kind: Database <2>

name: sampledatabase

version: v1alpha1

Good catch Pravin I added comment to the google doc

johusta · 2022-02-25T13:08:40Z

Looks Good To Me

pravin-dsilva · 2022-02-28T04:39:48Z

lgtm

rolfedh · 2022-02-28T12:48:51Z

modules/sbo-connecting-spring-petclinic-sample-app-to-postgresql-database-service-power-z.adoc

Suggested change

.Connecting spring-petclinic to sample database

.Connecting spring-petclinic to a sample database

rolfedh · 2022-02-28T12:51:50Z

modules/sbo-deploying-the-spring-petclinic-sample-application-power-z.adoc

Suggested change

It will take a few minutes until the `CrashLoopBackOff` status is displayed:

It takes a few minutes until the `CrashLoopBackOff` status is displayed:

rolfedh · 2022-02-28T12:52:11Z

modules/sbo-deploying-the-spring-petclinic-sample-application-power-z.adoc

Suggested change

At this stage, the pod fails to start. If you try to interact with the application, it will return errors.

At this stage, the pod fails to start. If you try to interact with the application, it returns errors.

rolfedh

Nice work. I made some minor suggestions.

Srivaralakshmi

@SNiemann15 Nice work! Just left a couple of suggestions; nitpicks. PTAL. Thanks!

Srivaralakshmi · 2022-02-28T13:13:42Z

modules/sbo-deploying-a-postgresql-database-operator-power-z.adoc

Suggested change

. After the operator is installed, list the operator subscriptions in `openshift-operators` namespace:

. After the operator is installed, list the operator subscriptions in the `openshift-operators` namespace:

Srivaralakshmi · 2022-02-28T13:17:55Z

modules/sbo-deploying-the-spring-petclinic-sample-application-power-z.adoc

Suggestion: Formatting issue. please check and rectifiy.

abrennan89 · 2022-03-01T15:59:16Z

/cherrypick enterprise-4.9

abrennan89 · 2022-03-01T15:59:32Z

/cherrypick enterprise-4.10

openshift-cherrypick-robot · 2022-03-01T15:59:57Z

@abrennan89: new pull request created: #42564

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-03-01T16:00:13Z

@abrennan89: new pull request created: #42565

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2022

SNiemann15 force-pushed the sbo101_ibmpz branch from 7471053 to 2b26a58 Compare February 18, 2022 15:46

pravin-dsilva reviewed Feb 18, 2022

View reviewed changes

Srivaralakshmi mentioned this pull request Feb 21, 2022

Quick start updates, Example updates, and Updates to SBO topics for modular-docs template and content type attributes alignment #41809

Merged

pmacik reviewed Feb 21, 2022

View reviewed changes

SNiemann15 force-pushed the sbo101_ibmpz branch 3 times, most recently from ec7e23b to 513ca9e Compare February 22, 2022 15:57

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022

SNiemann15 force-pushed the sbo101_ibmpz branch from 513ca9e to 1b9ebdc Compare February 23, 2022 15:05

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022

SNiemann15 force-pushed the sbo101_ibmpz branch 2 times, most recently from 93688bf to c42fa7e Compare February 24, 2022 10:58

pravin-dsilva reviewed Feb 24, 2022

View reviewed changes

SNiemann15 force-pushed the sbo101_ibmpz branch 3 times, most recently from efd4ee0 to 80f32c9 Compare February 25, 2022 08:38

rolfedh reviewed Feb 28, 2022

View reviewed changes

rolfedh approved these changes Feb 28, 2022

View reviewed changes

Srivaralakshmi suggested changes Feb 28, 2022

View reviewed changes

SNiemann15 force-pushed the sbo101_ibmpz branch from 80f32c9 to c3f5c1b Compare February 28, 2022 15:13

Srivaralakshmi mentioned this pull request Feb 28, 2022

SBO 1.0.1 Release updates #42505

Merged

sbo 1.0.1 changes for IBM Z and P

757b305

SNiemann15 force-pushed the sbo101_ibmpz branch from c3f5c1b to 757b305 Compare February 28, 2022 15:21

abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.9 branch/enterprise-4.10 labels Mar 1, 2022

abrennan89 added this to the Next Release milestone Mar 1, 2022

abrennan89 added the multi-arch Label for all IBM Power and Z PRs label Mar 1, 2022

abrennan89 merged commit 6a66323 into openshift:main Mar 1, 2022

openshift-cherrypick-robot mentioned this pull request Mar 1, 2022

[enterprise-4.9] RHEVDOCS3492, 3761: Aligned SBO 1.0.1 changes for IBM Z and Power #42564

Merged

openshift-cherrypick-robot mentioned this pull request Mar 1, 2022

[enterprise-4.10] RHEVDOCS3492, 3761: Aligned SBO 1.0.1 changes for IBM Z and Power #42565

Merged

SNiemann15 deleted the sbo101_ibmpz branch March 2, 2022 10:30

-  labels:
-    app: spring-petclinic
-   name: spring-petclinic
+  labels:
+    app: spring-petclinic
+  name: spring-petclinic

-    - group: postgresql.dev4devs.com
-      version: v1beta1
-      kind: Database <2>
-      name: sampledatabase
-      version: v1alpha1
+    - group: postgresql.dev4devs.com
+      kind: Database <2>
+      name: sampledatabase
+      version: v1alpha1

	.Connecting spring-petclinic to sample database
	.Connecting spring-petclinic to a sample database

	It will take a few minutes until the `CrashLoopBackOff` status is displayed:
	It takes a few minutes until the `CrashLoopBackOff` status is displayed:

	At this stage, the pod fails to start. If you try to interact with the application, it will return errors.
	At this stage, the pod fails to start. If you try to interact with the application, it returns errors.

	. After the operator is installed, list the operator subscriptions in `openshift-operators` namespace:
	. After the operator is installed, list the operator subscriptions in the `openshift-operators` namespace:

RHEVDOCS3492, 3761: Aligned SBO 1.0.1 changes for IBM Z and Power #42121

RHEVDOCS3492, 3761: Aligned SBO 1.0.1 changes for IBM Z and Power #42121

Uh oh!

Conversation

SNiemann15 commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johusta commented Feb 18, 2022

Uh oh!

Srivaralakshmi commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Srivaralakshmi commented Feb 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SNiemann15 commented Feb 21, 2022

Uh oh!

pmacik commented Feb 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmacik commented Feb 21, 2022

Uh oh!

johusta commented Feb 21, 2022

Uh oh!

pravin-dsilva Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johusta commented Feb 25, 2022

Uh oh!

pravin-dsilva commented Feb 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rolfedh left a comment

Choose a reason for hiding this comment

Uh oh!

Srivaralakshmi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abrennan89 commented Mar 1, 2022

Uh oh!

abrennan89 commented Mar 1, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 1, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

SNiemann15 commented Feb 18, 2022 •

edited

Loading

netlify bot commented Feb 18, 2022 •

edited

Loading

Srivaralakshmi commented Feb 21, 2022 •

edited

Loading

pravin-dsilva Feb 24, 2022 •

edited

Loading