Skip to content

Conversation

@ctauchen
Copy link
Contributor

@ctauchen ctauchen commented Feb 14, 2022

From RN tracker: #37586 (comment)

Preview: https://deploy-preview-41821--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-10-release-notes.html#ocp-4-10-notable-technical-changes

@s-urbaniak Can you check this to make sure I've got it right? Thanks!
@sjstout Anything you'd like to see different?

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2022
@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d6e9677

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620d1b09dafcd2000890baca

😎 Browse the preview: https://deploy-preview-41821--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-10-release-notes

@ctauchen ctauchen added branch/enterprise-4.10 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2022
@ctauchen ctauchen added this to the Future Release milestone Feb 14, 2022
[id="ocp-4-10-TLS-subject-alternative-names-required"]
==== TLS X.509 certificates must have Subject Alternative Names

X.509 certificates must have a properly set Subject Alternative Names field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so. This isn't a GUI field name. It's more of a key-value pair in a text file. The name Subject Alternative Name is a common name for this, but the actual key is something like subjectAltName.

==== TLS X.509 certificates must have Subject Alternative Names

X.509 certificates must have a properly set Subject Alternative Names field.
If you update your cluster without this, you risk breaking your cluster, rendering it inaccessible, or worse.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could be worse? Hard to imagine. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/or worse/and the servers will all catch fire, data centers for each distributed cluster will go offline, and YOU WILL BREAK THE CLOUD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said it was HARD to imagine, not impossible :-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the "or worse" from the release note. I get that this is an important warning, but "or worse" is pretty open-ended. Just my $.02 cents. :)

X.509 certificates must have a properly set Subject Alternative Names field.
If you update your cluster without this, you risk breaking your cluster, rendering it inaccessible, or worse.

In older versions of {product-title}, X.509 certificates worked without the Subject Alternative Names, so long as the Common Name field was set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two field names to bold.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

In older versions of {product-title}, X.509 certificates worked without the Subject Alternative Names, so long as the Common Name field was set.
link:https://docs.openshift.com/container-platform/4.6/release_notes/ocp-4-6-release-notes.html#ocp-4-6-tls-common-name[This behavior was removed in {product-title} 4.6].

In some cases, certificates without Subject Alternative Names continued to work in {product-title} 4.6, 4.7, 4.8, and 4.9.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@ctauchen ctauchen force-pushed the RN-4.10-SAN-required branch from a7425c5 to d9c842f Compare February 16, 2022 13:25
@nalhadef
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@sjstout
Copy link

sjstout commented Feb 16, 2022

LGTM!

@ctauchen ctauchen force-pushed the RN-4.10-SAN-required branch from d9c842f to d6e9677 Compare February 16, 2022 15:40
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@ctauchen ctauchen added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 21, 2022
@ctauchen ctauchen merged commit 7d841b9 into openshift:enterprise-4.10 Feb 21, 2022
@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants