Skip to content

Conversation

@stevsmit
Copy link
Member

@stevsmit stevsmit commented Dec 8, 2021

No BZ. Follow up to #39184

Preview: https://deploy-preview-39647--osdocs.netlify.app/openshift-enterprise/latest/architecture/control-plane#control-plane-and-node-host-compatibility

SME ack'd in private slack message:

W. Trevor King 4:03 PM
Both of those hit all the points I'm interested in

Please check for formatting.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2021
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d80d691

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61b75b2450054c00084fcc70

😎 Browse the preview: https://deploy-preview-39647--osdocs.netlify.app/openshift-enterprise/latest/architecture/control-plane

@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch 2 times, most recently from 6fdf2ba to 41d761b Compare December 9, 2021 21:22
@jeana-redhat
Copy link
Contributor

Just what I pinged you about in Slack - otherwise LGTM

@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch from d4b6db3 to ec3846f Compare December 10, 2021 19:29
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2021
@sferich888
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch from ec3846f to 503ec2f Compare December 10, 2021 21:32
@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch from 503ec2f to b487e0c Compare December 10, 2021 21:53
@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch from b487e0c to 5ff455e Compare December 13, 2021 14:33
Copy link
Contributor

@kmccarron-rh kmccarron-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise lgtm!

@stevsmit stevsmit force-pushed the BZ1900182-follow-up branch from 5ff455e to d80d691 Compare December 13, 2021 14:39
@stevsmit stevsmit merged commit bbddf67 into openshift:main Dec 13, 2021
@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@stevsmit: new pull request created: #39794

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.7

@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.8

@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.9

@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@stevsmit: new pull request created: #39795

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #39796

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #39797

Details

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #39798

Details

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants