Skip to content

OTA-472: Reorganizing and adding a channel management chapter #39613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sagidlow merged 1 commit into from
Dec 10, 2021
Merged

OTA-472: Reorganizing and adding a channel management chapter #39613

sagidlow merged 1 commit into from
Dec 10, 2021

Conversation

@sagidlow
Copy link
Contributor

@sagidlow sagidlow commented Dec 7, 2021 •
edited
Loading

Applies to 4.10+
JIRA Link: https://issues.redhat.com/browse/OTA-472
QE ack received on original PR (#36015). SME ack needed.
Preview: Understanding upgrade channels
The remaining sections have been updated to remove the redundancy.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2021
@sagidlow sagidlow added branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 peer-review-needed Signifies that the peer review team needs to review this PR and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021
@sagidlow sagidlow added this to the Next Release milestone Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: f42d0ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61b282f9d233010009d27978

😎 Browse the preview: https://deploy-preview-39613--osdocs.netlify.app/openshift-enterprise/latest/security/container_security/security-hosts-vms

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2021
@sagidlow sagidlow force-pushed the OTA-472 branch 5 times, most recently from 90681d7 to ec79513 Compare December 7, 2021 21:32
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021
@sagidlow sagidlow force-pushed the OTA-472 branch 10 times, most recently from 2739c11 to 0ef26dd Compare December 8, 2021 02:20
LalatenduMohanty
LalatenduMohanty approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
jeana-redhat
jeana-redhat reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! left just a couple questions

modules/understanding-upgrade-channels.adoc Outdated
Copy link
Contributor

@jeana-redhat jeana-redhat Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call giving these all ids

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 9, 2021
@sagidlow sagidlow mentioned this pull request Dec 9, 2021
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@sagidlow sagidlow force-pushed the OTA-472 branch 2 times, most recently from a8aa235 to b879dc8 Compare December 9, 2021 18:43
sagidlow
sagidlow commented Dec 9, 2021
View reviewed changes
@sagidlow sagidlow mentioned this pull request Dec 9, 2021
Merged
This was referenced Dec 9, 2021
Merged
Merged
LalatenduMohanty
LalatenduMohanty approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@sagidlow sagidlow merged commit c174bd7 into openshift:main Dec 10, 2021
@sagidlow
Copy link
Contributor Author

sagidlow commented Dec 10, 2021

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 10, 2021
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 10, 2021

@sagidlow: new pull request created: #39766

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sagidlow sagidlow mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

+1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

4 participants

@sagidlow @openshift-cherrypick-robot @LalatenduMohanty @jeana-redhat