Skip to content

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Sep 23, 2021

@adellape adellape added this to the Future Release milestone Sep 23, 2021
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2021
@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e16f311

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6153782ea58db9000741d94e

😎 Browse the preview: https://deploy-preview-36685--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2021
@adellape adellape force-pushed the osdk_sno_49 branch 13 times, most recently from a06a672 to 92477b8 Compare September 23, 2021 04:22
@emmajiafan
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 23, 2021
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions. Great job :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 23, 2021
Copy link

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2021

New changes are detected. LGTM label has been removed.

@adellape adellape merged commit a1a573d into openshift:main Sep 28, 2021
@adellape adellape deleted the osdk_sno_49 branch September 28, 2021 20:47
@adellape
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@adellape: new pull request created: #36868

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants