Skip to content

OSDOCS-2284: Added enabling multicast to ROSA and OSD with dedicated-admin ability… #36079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EricPonvelle merged 1 commit into from
Nov 10, 2021
Merged

OSDOCS-2284: Added enabling multicast to ROSA and OSD with dedicated-admin ability… #36079

EricPonvelle merged 1 commit into from
Nov 10, 2021

Conversation

@jonquilwilliams
Copy link
Contributor

@jonquilwilliams jonquilwilliams commented Sep 3, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2021
@netlify
Copy link

netlify bot commented Sep 3, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 1cc9d99

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61324371b77c30000756c90d

😎 Browse the preview: https://deploy-preview-36079--osdocs.netlify.app

@jonquilwilliams jonquilwilliams changed the title OSDOCS-2284: Added enabling multicast to ROSA and SOD with dedicated-admin ability… OSDOCS-2284: Added enabling multicast to ROSA and OSD with dedicated-admin ability… Sep 3, 2021
@yuwang-RH
Copy link
Member

yuwang-RH commented Sep 10, 2021

LGTM.

skrthomas
skrthomas approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EricPonvelle
Copy link
Contributor

EricPonvelle commented Sep 21, 2021 •
edited
Loading

@arendej can you please take a look at this PR for SME acknowledgement?

@arendej
Copy link
Contributor

arendej commented Sep 21, 2021 •
edited
Loading

for https://deploy-preview-36079--osdocs.netlify.app/openshift-dedicated/latest/networking/openshift_sdn/enabling-multicast.html
I tested this and the part in 4b where it says

To start the multicast listener, in a new terminal window or tab, enter the following command:

It's actually more appropriate to make the #4 step happen in another terminal tab/window, because 4b relies on 4a, which won't carry over to another terminal unless it's exported.

@EricPonvelle EricPonvelle added branch/dedicated peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 10, 2021
@EricPonvelle EricPonvelle added this to the Next Release milestone Nov 10, 2021
@EricPonvelle EricPonvelle merged commit 5705519 into openshift:dedicated-4 Nov 10, 2021
@EricPonvelle EricPonvelle added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrthomas skrthomas skrthomas approved these changes

Assignees

No one assigned

Labels

branch/dedicated peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@jonquilwilliams @yuwang-RH @EricPonvelle @arendej @skrthomas