[enterprise-4.9] modules/update-service-mirror-release: Use 'oc image mirror ...' for the release image #34971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the release image
We can't use:
$ oc adm release mirror ...
to split the release image out into LOCAL_RELEASE_IMAGES_REPOSITORY,
because oc does not currently understand mirroring. So there's no way
to tell it "the referenced images you're looking for are actually in
${LOCAL_REGISTRY}/${TEMP_REPOSITORY}", and it fails with:
error: unable to connect to quay.io/openshift-release-dev/ocp-v4.0-art-dev: Get "https://quay.io/v2/"...
error: an error occurred during planning
Instead, send the images from disk directly to the target repositoy
for referenced images, and then use 'oc image mirror' again to copy
the release image over to the release-image repository without
worrying about referenced images. We still need the release images in
that separate repository to avoid Cincinnati consuming excessive
memory trying to load referenced-image layers as if they were release
images [1,2].
I've also softened some REMOVABLE_MEDIA_PATH wording. The important
point is that REMOVABLE_MEDIA_PATH points to where the removable media
is mounted for both commands, not that you use the same path string.
For example, maybe you mounted to /mnt/a on your external machine, and
then mounted that media to /mnt/b on your internal machine. You'd
want to use /mnt/b for REMOVABLE_MEDIA_PATH when mirroring from disk,
not /mnt/a.
[1]: openshift#29630 (comment)
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1850781
openshift-ci
bot
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #33841
/assign bergerhoffer