-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Document enabling wildcard routes in the web console #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document enabling wildcard routes in the web console #3439
Conversation
| $ oc scale dc/router --replicas=1 | ||
| ---- | ||
|
|
||
| xref:../../install_config/web_console_customization.adoc#web-console-enable-wildcard-routes[Learn how to configure the web console for wildcard routes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this consistent with how we normally link to other doc pages, seems like a lot of link text
cc @ahardin-rh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwforres Yes, this seems verbose, but it is correct.
| routes in the web console. This lets users enter hostnames starting with an | ||
| asterisk like `*.example.com` when creating a route. To enable wildcard routes: | ||
|
|
||
| . Save this script to a file (for example, *_enable-wildcard-routes.js_*): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are missing the actual script content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, my eyes were skipping right over it
knobunc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
@ahardin-rh ok technical review is done on this |
|
Is this for 3.4? |
|
@ahaile-redhat it's for 3.5 |
|
Will do some minor follow-up edits in a follow-up PR. Thanks! |
|
[rev_history] |
openshift/origin-web-console#853
https://trello.com/c/GEdeKzea