Skip to content

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 3, 2017

@spadgett spadgett requested review from jwforres and knobunc January 3, 2017 15:23
$ oc scale dc/router --replicas=1
----

xref:../../install_config/web_console_customization.adoc#web-console-enable-wildcard-routes[Learn how to configure the web console for wildcard routes].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this consistent with how we normally link to other doc pages, seems like a lot of link text
cc @ahardin-rh ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwforres Yes, this seems verbose, but it is correct.

routes in the web console. This lets users enter hostnames starting with an
asterisk like `*.example.com` when creating a route. To enable wildcard routes:

. Save this script to a file (for example, *_enable-wildcard-routes.js_*):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are missing the actual script content

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, my eyes were skipping right over it

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jwforres
Copy link
Member

jwforres commented Jan 3, 2017

@ahardin-rh ok technical review is done on this

@ahardin-rh
Copy link
Contributor

Is this for 3.4?

@spadgett
Copy link
Member Author

spadgett commented Jan 3, 2017

@ahaile-redhat it's for 3.5

@ahardin-rh
Copy link
Contributor

Will do some minor follow-up edits in a follow-up PR. Thanks!

@ahardin-rh ahardin-rh merged commit 79965a4 into openshift:master Jan 5, 2017
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../install_config/web_console_customization.adoc#install-config-web-console-customization[Customizing the Web Console]
|Added a new section on xref:../install_config/web_console_customization.adoc#web-console-enable-wildcard-routes[enabling wildcard routes] in the web console.
%

@spadgett spadgett deleted the web-console-wildcard-routes branch March 23, 2017 23:24
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.5 GA Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants