-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add OSDK v1.8.0 upgrade guide for OCP 4.8 #33613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: d7b1e95 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dbe633525732000817cda3 😎 Browse the preview: https://deploy-preview-33613--osdocs.netlify.app |
e363ad9 to
ae9dafa
Compare
65fc4fe to
7b86eb0
Compare
7b86eb0 to
9ca20eb
Compare
1d83c15 to
cefa7cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML with a blank line? As long as you feel like customers can recognize what to specify for the resourceName field, then it's cool by me. I don't know the subject area, so I'm unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah I'm not sure either. Came from https://github.com/operator-framework/operator-sdk/blob/2a1bd03/testdata/ansible/memcached-operator/config/manager/controller_manager_config.yaml.
I'll change the value to a user-replaceable <resource_name> for now. @rashmigottipati @varshab1210 Do you have a suggestion?
mikemckiernan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check for the oops, otherwise, you know what to act on and what to ignore better than I do.
Interesting read.
671ca00 to
ce64b50
Compare
|
@adellape I only have one suggestion for this pr.
I think it should be and no need to change b.Move leases.coordination.k8s.io to its own proxy-role rule. |
ce64b50 to
d7b1e95
Compare
@cuipinghuo You're right! I've combined the changes for step 7 (no more 7a and 7b). |
|
/cherrypick enterprise-4.8 |
|
@adellape: new pull request created: #34155 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://issues.redhat.com/browse/OSDOCS-1958
OCP 4.8 supports OSDK v1.8.0, and this new guide shows how to manually upgrade your existing Operator projects for compatibility with the new OSDK version.
Preview: Upgrading projects for newer Operator SDK versions