Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jun 14, 2021

OSDOCS-2081 - Adds 4.8 Release Note for new stream metadata sub-command for openshift-install in UPI clusters. Relates to #33415, which is currently under review.

@cgwalters and @miabbott PTAL for Eng/QE review. Thanks!

Preview link: https://deploy-preview-33424--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-8-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-8-stream-metadata

@bobfuru bobfuru added this to the Future Release milestone Jun 14, 2021
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2021
@netlify
Copy link

netlify bot commented Jun 14, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: a9f4d8f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d4d2c0e30c1300070e22aa

😎 Browse the preview: https://deploy-preview-33424--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-8-release-notes

@miabbott
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 18, 2021
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 19, 2021
@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 19, 2021
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, LGTM

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 21, 2021
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
@bobfuru bobfuru merged commit 7045e0e into openshift:enterprise-4.8 Jun 24, 2021
@bobfuru bobfuru deleted the OSDOCS-2081 branch June 24, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants