-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BZ1970130: Clarify RHCOS image template creation for vSphere #33371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 65862a7 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60c39d322cf71b00088f9d01 😎 Browse the preview: https://deploy-preview-33371--osdocs.netlify.app |
|
@staebler Could you PTAL or suggest someone on your team who could review this for technical accuracy, please? Thanks! Cc: @miabbott (RHCOS) and @kalexand-rh and @pneedle-rh (Docs) |
|
Cc: @rvanderp3 - For your awareness. Not sure if this might have an impact on what you reported in https://bugzilla.redhat.com/show_bug.cgi?id=1967707? |
|
This seems reasonable. I'll tag @jcpowermac or @rvanderp3 for vSphere expertise. |
|
cc @jinyunma |
|
LGTM |
LGTM |
|
/lgtm |
|
@bobfuru A couple of questions. Otherwise LGTM |
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
@bobfuru: #33371 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: #33371 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: new pull request created: #33513 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: new pull request created: #33514 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ1970130 - I have tried to identify all refs to the OVF template usage in vCenter that would benefit from this distinction. Actually testing the workflow in vCenter is not possible for me, so I relied on an OVF template demo video to verify certain vCenter UI elements. This will be applied to OCP 4.5+ docs.
PREVIEW LINKS: