Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jun 11, 2021

BZ1970130 - I have tried to identify all refs to the OVF template usage in vCenter that would benefit from this distinction. Actually testing the workflow in vCenter is not possible for me, so I relied on an OVF template demo video to verify certain vCenter UI elements. This will be applied to OCP 4.5+ docs.

PREVIEW LINKS:

@bobfuru bobfuru added this to the Next Release milestone Jun 11, 2021
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2021
@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 65862a7

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60c39d322cf71b00088f9d01

😎 Browse the preview: https://deploy-preview-33371--osdocs.netlify.app

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 11, 2021

@staebler Could you PTAL or suggest someone on your team who could review this for technical accuracy, please?
@jianlinliu Could you PTAL for QE?

Thanks!

Cc: @miabbott (RHCOS) and @kalexand-rh and @pneedle-rh (Docs)

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 11, 2021

Cc: @rvanderp3 - For your awareness. Not sure if this might have an impact on what you reported in https://bugzilla.redhat.com/show_bug.cgi?id=1967707?

@miabbott
Copy link
Member

This seems reasonable. I'll tag @jcpowermac or @rvanderp3 for vSphere expertise.

@vikram-redhat vikram-redhat changed the title BZ1970130 - Clarify RHCOS image template creation for vSphere BZ1970130: Clarify RHCOS image template creation for vSphere Jun 13, 2021
@jianlinliu
Copy link

cc @jinyunma

@jinyunma
Copy link

LGTM

@rvanderp3
Copy link
Contributor

This seems reasonable. I'll tag @jcpowermac or @rvanderp3 for vSphere expertise.

LGTM

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 16, 2021
@mburke5678
Copy link
Contributor

mburke5678 commented Jun 16, 2021

@bobfuru A couple of questions. Otherwise LGTM

@bobfuru bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 16, 2021
@bobfuru bobfuru merged commit 78cdfa4 into openshift:master Jun 16, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 16, 2021

/cherrypick enterprise-4.5

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 16, 2021

/cherrypick enterprise-4.6

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 16, 2021

/cherrypick enterprise-4.7

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 16, 2021

/cherrypick enterprise-4.8

@bobfuru bobfuru deleted the BZ1970130 branch June 16, 2021 16:30
@openshift-cherrypick-robot

@bobfuru: #33371 failed to apply on top of branch "enterprise-4.5":

Applying: BZ1970130 - Clarify RHCOS image template creation for vSphere
Using index info to reconstruct a base tree...
M	modules/installation-vsphere-machines.adoc
A	modules/windows-machineset-vsphere.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/windows-machineset-vsphere.adoc deleted in HEAD and modified in BZ1970130 - Clarify RHCOS image template creation for vSphere. Version BZ1970130 - Clarify RHCOS image template creation for vSphere of modules/windows-machineset-vsphere.adoc left in tree.
Auto-merging modules/installation-vsphere-machines.adoc
CONFLICT (content): Merge conflict in modules/installation-vsphere-machines.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ1970130 - Clarify RHCOS image template creation for vSphere
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bobfuru: #33371 failed to apply on top of branch "enterprise-4.6":

Applying: BZ1970130 - Clarify RHCOS image template creation for vSphere
Using index info to reconstruct a base tree...
A	modules/windows-machineset-vsphere.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/windows-machineset-vsphere.adoc deleted in HEAD and modified in BZ1970130 - Clarify RHCOS image template creation for vSphere. Version BZ1970130 - Clarify RHCOS image template creation for vSphere of modules/windows-machineset-vsphere.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ1970130 - Clarify RHCOS image template creation for vSphere
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bobfuru: new pull request created: #33513

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bobfuru: new pull request created: #33514

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants