Skip to content

Apply peer review feedback from PR29360 #33119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobfuru merged 1 commit into from
Jun 7, 2021
Merged

Apply peer review feedback from PR29360 #33119

bobfuru merged 1 commit into from
Jun 7, 2021

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jun 4, 2021 •
edited
Loading

@bobfuru bobfuru added this to the Next Release milestone Jun 4, 2021
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2021
@netlify
Copy link

netlify bot commented Jun 4, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 45e5f4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60be5dd52ccef30007453070

😎 Browse the preview: https://deploy-preview-33119--osdocs.netlify.app

@bobfuru bobfuru force-pushed the 29630-peer-review branch from caa8573 to 57017d9 Compare June 4, 2021 21:58
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 4, 2021

@LalatenduMohanty and @jottofar - This PR applies feedback based on review from @bergerhoffer and I. Could one of you PTAL and let me know if this lgty? Thanks!

jottofar
jottofar reviewed Jun 7, 2021
View reviewed changes
jottofar
jottofar reviewed Jun 7, 2021
View reviewed changes
@bobfuru bobfuru force-pushed the 29630-peer-review branch from 57017d9 to 7c2d1ef Compare June 7, 2021 14:03
@jottofar
Copy link
Contributor

jottofar commented Jun 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
LalatenduMohanty
LalatenduMohanty suggested changes Jun 7, 2021
View reviewed changes
@bobfuru bobfuru force-pushed the 29630-peer-review branch from 7c2d1ef to 63ec10c Compare June 7, 2021 15:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
LalatenduMohanty
LalatenduMohanty approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 7, 2021

@bergerhoffer PTAL, thanks!

bergerhoffer
bergerhoffer reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things. Thanks again for following up on this!

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 7, 2021
bobfuru
bobfuru commented Jun 7, 2021
View reviewed changes
Copy link
Contributor Author

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bergerhoffer! I agree with your feedback and have updated accordingly.

@bobfuru bobfuru force-pushed the 29630-peer-review branch from 63ec10c to 45e5f4e Compare June 7, 2021 17:56
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@bobfuru bobfuru merged commit 9feeb88 into openshift:master Jun 7, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 7, 2021

/cherrypick enterprise-4.8

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 7, 2021

/cherrypick enterprise-4.7

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 7, 2021

/cherrypick enterprise-4.6

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 7, 2021

/cherrypick enterprise-4.5

@bobfuru bobfuru deleted the 29630-peer-review branch June 7, 2021 18:01
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 7, 2021

@bobfuru: new pull request created: #33175

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 7, 2021

@bobfuru: new pull request created: #33176

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 7, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 7, 2021

@bobfuru: new pull request created: #33177

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+2 more reviewers

@jottofar jottofar jottofar left review comments

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

@jottofar jottofar

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@bobfuru @jottofar @openshift-cherrypick-robot @LalatenduMohanty @bergerhoffer