-
Notifications
You must be signed in to change notification settings - Fork 1.9k
modules/understanding-upgrade-channels: Blocked update edges are still supported #32091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/understanding-upgrade-channels: Blocked update edges are still supported #32091
Conversation
…l supported If we supported them at some point, we will continue to support the edges even if they are no longer recommended.
|
Deploy preview for osdocs ready! Built with commit 26e6938 |
|
@jiajliu can you ACK from a QE perspective? @sferich888 since this is updating some support statements, can you confirm? |
|
/lgtm |
|
@sferich888 I'm going to label this with 4.5+ to mark it for cherrypicking into all current and future branches. Let me know if any of those should be omitted. |
|
@jeana-redhat @codyhoag What's left to move this out? Given that this is all after QE has signed off on releases (we only ship errata after their sign off) I'm not sure they'll be concerned about this change at all. |
|
LGTM. |
|
@sdodson thanks for following up. Looks like we thought we needed QE ack, and now we have it even though as you say it's not required. Only outstanding question as far as I know is confirmation that this goes into all releases (4.5+) - do you know if that's right? If so, I'll review for docs compliance and merge/cherrypick. |
jeana-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs review: lgtm
|
@jeana-redhat yes, all currently supported versions is fine |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.5 |
|
@jeana-redhat: new pull request created: #32814 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sdodson ACK and done - tyvm! 👍 |
|
@jeana-redhat: #32091 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeana-redhat: new pull request created: #32815 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeana-redhat: new pull request created: #32816 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.7 |
|
@jeana-redhat: #32091 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If we supported them at some point, we will continue to support the edges even if they are no longer recommended.