OSDOCS-1769 Installing a cluster on AWS in a restricted network #31935

codyhoag · 2021-04-26T18:22:57Z

https://issues.redhat.com/browse/OSDOCS-1769

Previews:

netlify · 2021-04-26T18:28:18Z

Deploy preview for osdocs ready!

Built with commit 388663b

https://deploy-preview-31935--osdocs.netlify.app

codyhoag · 2021-04-26T19:14:00Z

@yunjiang29 PTAL. Thanks!

yunjiang29 · 2021-05-07T10:47:29Z

Hello @codyhoag
per my understanding, since the restrict cluster need to access existing mirror registry server, so the pre-created VPC is required for installing restrict cluster, e.g. the bastion host/mirror registry/cluster are in the same VPC.

If VPC is created by installer, the cluster can not access mirror registry which is in another VPC, since they are in different VPC and there is no VPC peering connection between two different VPC.

So based on above info, the following parameters are required: platform.aws.subnets, imageContentSources and additionalTrustBundle, the sample install-config.yaml should also include platform.aws.subnets

Also please @staebler help to review, thanks.

staebler · 2021-05-07T19:18:32Z

Hello @codyhoag
per my understanding, since the restrict cluster need to access existing mirror registry server, so the pre-created VPC is required for installing restrict cluster, e.g. the bastion host/mirror registry/cluster are in the same VPC.

If VPC is created by installer, the cluster can not access mirror registry which is in another VPC, since they are in different VPC and there is no VPC peering connection between two different VPC.

So based on above info, the following parameters are required: platform.aws.subnets, imageContentSources and additionalTrustBundle, the sample install-config.yaml should also include platform.aws.subnets

Also please @staebler help to review, thanks.

Yes, to install a restricted-network cluster, the user must provide a pre-created VPC.

codyhoag · 2021-05-07T20:48:34Z

@yunjiang29 I have updated this PR to include instructions for providing an existing VPC (included in second commit). Let me know if you have any additional feedback. Thanks!

installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc

staebler · 2021-05-07T21:21:19Z

installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc

Is this new text? Or is this the same text that we use elsewhere? This text implies that the user is not using manual creds mode, right?

@staebler This is a note we provide in all AWS install guides. It originated from doc bug BZ#1724684 a couple years ago. Is it still relevant?

We can circle back to this if we want to update it in another PR, since this affects all AWS install guides.

Yes, certainly, let's not try to address it in this PR.

modules/installation-aws-config-yaml.adoc

modules/installation-initializing.adoc

installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc

codyhoag · 2021-05-09T02:35:07Z

@staebler I addressed your feedback (with one question). Let me know if any further clarifications are needed. Thanks!

yunjiang29 · 2021-05-10T10:53:04Z

@codyhoag the numbers in sample install-config are not correct, e.g. baseDomain, metadata.name, platform.aws.regionhave the same number 1

codyhoag · 2021-05-10T13:32:29Z

@codyhoag the numbers in sample install-config are not correct, e.g. baseDomain, metadata.name, platform.aws.region have the same number 1

@yunjiang29 that is intended. Those values are all prompted by the installation program, which is what 1 is meant to describe.

yunjiang29 · 2021-05-11T02:00:35Z

@codyhoag get it, thanks. LGTM.

staebler

LGTM

kalexand-rh

I have two small tweaks, but this otherwise LGTM!

installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc

installing/installing-preparing.adoc

codyhoag · 2021-05-11T19:48:54Z

/cherrypick enterprise-4.8

codyhoag · 2021-05-11T19:48:58Z

/cherrypick enterprise-4.7

codyhoag · 2021-05-11T19:49:03Z

/cherrypick enterprise-4.6

codyhoag · 2021-05-11T19:49:08Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2021-05-11T19:49:34Z

@codyhoag: #31935 failed to apply on top of branch "enterprise-4.7":

Applying: Installing a cluster on AWS in a restricted network
.git/rebase-apply/patch:493: trailing whitespace.
subnets: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	modules/installation-about-restricted-network.adoc
M	modules/installation-aws-config-yaml.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-custom-aws-vpc.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-custom-aws-vpc.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-aws-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-aws-config-yaml.adoc
Auto-merging modules/installation-about-restricted-network.adoc
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on AWS in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-11T19:49:35Z

@codyhoag: new pull request created: #32443

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-11T19:49:39Z

@codyhoag: #31935 failed to apply on top of branch "enterprise-4.6":

Applying: Installing a cluster on AWS in a restricted network
.git/rebase-apply/patch:493: trailing whitespace.
subnets: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	installing/install_config/installing-restricted-networks-preparations.adoc
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-aws-config-yaml.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-custom-aws-vpc.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-custom-aws-vpc.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-aws-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-aws-config-yaml.adoc
Auto-merging modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on AWS in a restricted network. Version Installing a cluster on AWS in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging installing/install_config/installing-restricted-networks-preparations.adoc
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on AWS in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-11T19:49:43Z

@codyhoag: #31935 failed to apply on top of branch "enterprise-4.5":

Applying: Installing a cluster on AWS in a restricted network
.git/rebase-apply/patch:493: trailing whitespace.
subnets: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	installing/install_config/installing-restricted-networks-preparations.adoc
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cli-logging-in-kubeadmin.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-aws-config-yaml.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-custom-aws-vpc.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-custom-aws-vpc.adoc
Auto-merging modules/installation-configure-proxy.adoc
CONFLICT (content): Merge conflict in modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-aws-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-aws-config-yaml.adoc
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-logging-in-kubeadmin.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on AWS in a restricted network. Version Installing a cluster on AWS in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging installing/install_config/installing-restricted-networks-preparations.adoc
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on AWS in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codyhoag added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 labels Apr 26, 2021

codyhoag added this to the Next Release milestone Apr 26, 2021

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2021

codyhoag force-pushed the aws-restricted-network branch from 5a89494 to 5edd5ba Compare April 26, 2021 18:46

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2021

codyhoag force-pushed the aws-restricted-network branch from cdd7fad to a4af599 Compare May 7, 2021 20:40

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2021

codyhoag force-pushed the aws-restricted-network branch from a4af599 to c29038c Compare May 7, 2021 20:44

staebler reviewed May 7, 2021

View reviewed changes

codyhoag force-pushed the aws-restricted-network branch from 834470a to 0d8254f Compare May 11, 2021 13:20

codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label May 11, 2021

staebler approved these changes May 11, 2021

View reviewed changes

kalexand-rh reviewed May 11, 2021

View reviewed changes

installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc Outdated Show resolved Hide resolved

installing/installing-preparing.adoc Outdated Show resolved Hide resolved

kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 11, 2021

Installing a cluster on AWS in a restricted network

388663b

codyhoag force-pushed the aws-restricted-network branch from 0d8254f to 388663b Compare May 11, 2021 15:18

codyhoag merged commit 30b657e into openshift:master May 11, 2021

openshift-cherrypick-robot mentioned this pull request May 11, 2021

[enterprise-4.8] OSDOCS-1769 Installing a cluster on AWS in a restricted network #32443

Merged

OSDOCS-1769 Installing a cluster on AWS in a restricted network #31935

OSDOCS-1769 Installing a cluster on AWS in a restricted network #31935

Uh oh!

Conversation

codyhoag commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codyhoag commented Apr 26, 2021

Uh oh!

yunjiang29 commented May 7, 2021

Uh oh!

staebler commented May 7, 2021

Uh oh!

codyhoag commented May 7, 2021

Uh oh!

Uh oh!

staebler May 7, 2021

Choose a reason for hiding this comment

Uh oh!

codyhoag May 9, 2021

Choose a reason for hiding this comment

Uh oh!

codyhoag May 11, 2021

Choose a reason for hiding this comment

Uh oh!

staebler May 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codyhoag commented May 9, 2021

Uh oh!

yunjiang29 commented May 10, 2021

Uh oh!

codyhoag commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yunjiang29 commented May 11, 2021

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

kalexand-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codyhoag commented May 11, 2021

Uh oh!

codyhoag commented May 11, 2021

Uh oh!

codyhoag commented May 11, 2021

Uh oh!

codyhoag commented May 11, 2021

Uh oh!

openshift-cherrypick-robot commented May 11, 2021

Uh oh!

openshift-cherrypick-robot commented May 11, 2021

Uh oh!

openshift-cherrypick-robot commented May 11, 2021

Uh oh!

openshift-cherrypick-robot commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codyhoag commented Apr 26, 2021 •

edited

Loading

netlify bot commented Apr 26, 2021 •

edited

Loading

codyhoag commented May 10, 2021 •

edited

Loading