Skip to content

OSDOCS-1993 Providing a private hosted zone on AWS#31315

Merged
codyhoag merged 1 commit intoopenshift:masterfrom
codyhoag:osdocs-1993-aws-hostedzone
Apr 30, 2021
Merged

OSDOCS-1993 Providing a private hosted zone on AWS#31315
codyhoag merged 1 commit intoopenshift:masterfrom
codyhoag:osdocs-1993-aws-hostedzone

Conversation

@codyhoag
Copy link
Copy Markdown
Contributor

@codyhoag codyhoag commented Apr 6, 2021

@codyhoag codyhoag added this to the Future Release milestone Apr 6, 2021
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 6, 2021

Deploy preview for osdocs ready!

Built with commit 0625064

https://deploy-preview-31315--osdocs.netlify.app

@codyhoag
Copy link
Copy Markdown
Contributor Author

@staebler please review and let me know if I left out any details. Thanks!

Comment thread modules/installation-configuration-parameters.adoc Outdated
@codyhoag codyhoag force-pushed the osdocs-1993-aws-hostedzone branch from 9c237b6 to 61396e5 Compare April 15, 2021 17:18
@codyhoag
Copy link
Copy Markdown
Contributor Author

@yunjiang29 PTAL

Comment thread modules/installation-aws-config-yaml.adoc Outdated
Comment thread modules/installation-configuration-parameters.adoc Outdated
@codyhoag codyhoag force-pushed the osdocs-1993-aws-hostedzone branch from 61396e5 to 751e9e2 Compare April 21, 2021 17:44
Copy link
Copy Markdown

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyhoag codyhoag force-pushed the osdocs-1993-aws-hostedzone branch from 751e9e2 to 0625064 Compare April 28, 2021 19:48
@codyhoag
Copy link
Copy Markdown
Contributor Author

@yunjiang29 can you confirm? Thanks!

@yunjiang29
Copy link
Copy Markdown
Contributor

@codyhoag LGTM

@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 30, 2021
Copy link
Copy Markdown
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 30, 2021
@codyhoag codyhoag merged commit 79285bf into openshift:master Apr 30, 2021
@codyhoag
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown

@codyhoag: new pull request created: #32092

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants