-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-2014 Installing VMC IPI into restricted network #31268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-2014 Installing VMC IPI into restricted network #31268
Conversation
|
Deploy preview for osdocs ready! Built with commit ee37f23 |
|
@jinyunma PTAL |
|
In section About installations in restricted networks, the IMPORTANT part mainly describes the UPI installation while this is IPI installation doc, it's better to be removed here, WDYT? |
|
I found that in Installing a cluster on VMC in a restricted network with user-provisioned infrastructure, it also describes Configuring the cluster-wide proxy during installation, which also supports in IPI installation in a restricted network. It's better to be added in this doc. |
|
@jinyunma I have addressed your feedback. Can you take a second look? Thanks! |
|
@codyhoag, LGTM for update. I have one more question, when reviewing doc Installing a cluster on vSphere in a restricted network, I didn't notice this part, sorry for this. Could you also help to update that doc if possible? |
96525fa to
ee37f23
Compare
|
@jinyunma sure thing! Just added that proxy config section to vSphere IPI restricted networks sections to make them uniform. Thanks! |
|
@codyhoag LGTM! Nicely done. 🚀 |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
@codyhoag: new pull request created: #31532 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@codyhoag: new pull request created: #31533 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@codyhoag: #31268 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://issues.redhat.com/browse/OSDOCS-2014
Previews: