Skip to content

Edits/formatting to auth arch/admin topics. #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adellape merged 1 commit into from
Apr 23, 2015
Merged

Edits/formatting to auth arch/admin topics. #312

adellape merged 1 commit into from
Apr 23, 2015

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Apr 21, 2015

In addition to general edits for style/formatting:

  • Moved the content about selecting an identity provider & other options into its own Admin Guide -> "Configuring Authentication" topic.
  • Left the rest of the auth content in the Arch dir (Arch -> Addtl Concepts -> "Authentication").
  • Moved the "Master and Node Configuration" topic to the Admin Guide.
  • Fixed links broken by the recent restructure.

@liggitt PTAL for tech review? If preferred, I've linked to an internal build in the following related Docs card: https://trello.com/c/dttOdxgh

bfallonf
bfallonf reviewed Apr 23, 2015
View reviewed changes
admin_guide/configuring_authentication.adoc Outdated
Copy link

@bfallonf bfallonf Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape Typo: "...using a your desired..."

Copy link
Contributor Author

@adellape adellape Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@adellape
Copy link
Contributor Author

adellape commented Apr 23, 2015

@tpoitras @bfallonf Comments addressed, thanks.

In the interest of landing these directory changes so that I can update some links in the training docs, I'm going to go ahead and merge this now. @liggitt When you're back, lmk if you have any additional feedback and I'll get them addressed.

adellape added a commit that referenced this pull request Apr 23, 2015
@adellape
Merge pull request #312 from adellape/oauth_edits
8e58396 
Edits/formatting to auth arch/admin topics.
@adellape adellape merged commit 8e58396 into openshift:master Apr 23, 2015
liggitt
liggitt reviewed Apr 24, 2015
View reviewed changes
admin_guide/configuring_authentication.adoc
Copy link

@liggitt liggitt Apr 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the hostedDomain bits added in #306

@liggitt
Copy link

liggitt commented Apr 24, 2015

Looks fine once #306 gets added back in

@adellape adellape mentioned this pull request Apr 28, 2015
Merged
@adellape adellape deleted the oauth_edits branch April 29, 2015 21:34
sbeskin-redhat pushed a commit to sbeskin-redhat/openshift-docs that referenced this pull request Oct 24, 2022
@apinnick
Merge pull request openshift#312 from apinnick/test-branch
028a1b0 
Test branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adellape @liggitt @bfallonf