Skip to content

Adding examples for viewing OAuth API server audit logs #30435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 1 commit into from
Mar 17, 2021
Merged

Adding examples for viewing OAuth API server audit logs #30435

bergerhoffer merged 1 commit into from
Mar 17, 2021

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 14, 2021 •
edited
Loading

@bergerhoffer bergerhoffer added this to the Next Release milestone Mar 14, 2021
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2021
@bergerhoffer bergerhoffer changed the title Adding examples for viewing OAuth API server audit logs [WIP] Adding examples for viewing OAuth API server audit logs Mar 14, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2021
@netlify
Copy link

netlify bot commented Mar 14, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit c8be92a

https://deploy-preview-30435--osdocs.netlify.app

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 14, 2021

@p0lyn0mial / @sttts Can you make sure these updates look okay for including the OAuth API server audit logs in these examples?

Preview: https://deploy-preview-30435--osdocs.netlify.app/openshift-enterprise/latest/security/audit-log-view.html#nodes-nodes-audit-log-basic-viewing_audit-log-view

@Anandnatraj
Copy link

Anandnatraj commented Mar 15, 2021

LGTM, @bergerhoffer thanks for the quick turnaround!

@bergerhoffer bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 15, 2021
@bergerhoffer bergerhoffer changed the title [WIP] Adding examples for viewing OAuth API server audit logs Adding examples for viewing OAuth API server audit logs Mar 15, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021
@pneedle-rh pneedle-rh self-requested a review March 15, 2021 16:05
pneedle-rh
pneedle-rh reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@pneedle-rh pneedle-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergerhoffer I have now completed my review. Aside from a few minor suggestions, this looks good to me!

@pneedle-rh pneedle-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 15, 2021
@bergerhoffer bergerhoffer force-pushed the adding-oauth-api-server-example branch from 728c124 to c8be92a Compare March 15, 2021 18:22
@p0lyn0mial
Copy link

p0lyn0mial commented Mar 16, 2021

@p0lyn0mial / @sttts Can you make sure these updates look okay for including the OAuth API server audit logs in these examples?

Yes, SGTM, The OAuth API server is an extension API and already produces the audit logs.

It assumes that the name of the pod and the log location is stable - which shouldn't change in the future since we don't allow for them to be customized.

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 16, 2021

@xingxingxia Can you please review these updates? We're adding examples to the audit log docs for the OAuth API server.

Preview: https://deploy-preview-30435--osdocs.netlify.app/openshift-enterprise/latest/security/audit-log-view.html#nodes-nodes-audit-log-basic-viewing_audit-log-view

@xingxingxia
Copy link
Contributor

xingxingxia commented Mar 17, 2021

@rhpmali could you take a review of this?

@rhpmali
Copy link

rhpmali commented Mar 17, 2021

Tried and tested commands and output looks good.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@bergerhoffer bergerhoffer merged commit 6418f35 into openshift:master Mar 17, 2021
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 17, 2021

/cherrypick enterprise-4.8

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 17, 2021

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 17, 2021

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 17, 2021

@bergerhoffer: new pull request created: #30593

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 17, 2021

@bergerhoffer: new pull request created: #30594

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 17, 2021

@bergerhoffer: new pull request created: #30595

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the adding-oauth-api-server-example branch August 3, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pneedle-rh pneedle-rh pneedle-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhpmali rhpmali

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

8 participants

@bergerhoffer @Anandnatraj @p0lyn0mial @xingxingxia @rhpmali @openshift-cherrypick-robot @pneedle-rh @openshift-ci-robot