Bug Fixes for ODC 4.7 #30299
Merged
Bug Fixes for ODC 4.7 #30299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
Deploy preview for osdocs ready! Built with commit be92fd0 |
yhontyk
reviewed
Mar 11, 2021
Contributor
There was a problem hiding this comment.
Suggested change
| * Previously, in the *YAML view* of the Helm installation form only the YAML schema or code was shown. There was no option to provide and view comments with parameters. Now you can view parameters in defined order with comments. A *Schema* viewer is added to the page, next to *YAML* editor to check all the schema objects present in the Helm Chart. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1886861[*BZ#1886861*]) | |
| * Previously, in the *YAML view* of the Helm installation form only the YAML schema or code was shown. There was no option to provide and view comments with parameters. Now you can view parameters in a defined order with comments. A *Schema* viewer is added to the page, next to the *YAML* editor to check all the schema objects present in the Helm Chart. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1886861[*BZ#1886861*]) |
openshift-ci-robot
added
needs-rebase
rohitkrai03
suggested changes
Mar 16, 2021
There was a problem hiding this comment.
YAML schema was not shown earlier. Only YAML code was shown. This bug fix adds the schema viewer in yaml editor. Also, the comments are not shown in YAML code. Only the schema and its descriptions.
Contributor
Author
There was a problem hiding this comment.
Thanks for the clarification @rohitkrai03. Will update the content based on this comment.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has additional Bugfixes for the ODC 4.7.