Skip to content

Conversation

@StephenJamesSmith
Copy link
Contributor

@wking @[email protected] - Plz verify/approve (lgtm).

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2021
@netlify
Copy link

netlify bot commented Mar 9, 2021

Deploy preview for osdocs ready!

Built with commit 9a2a56f

https://deploy-preview-30285--osdocs.netlify.app

@vikram-redhat
Copy link
Contributor

@kenyis - PTAL.

@vikram-redhat
Copy link
Contributor

@wking @sferich888 @kenyis @StephenJamesSmith - not sure who can answer this, but we recently added this release note entry via an exception process (#29835).

I am trying to figure out why this entry needs to change so soon after that. Was something missed in the original explanations? Is there someone whose ack we should have taken before publishing it that we didn't?

Changing release notes in between releases does require us to notify stakeholders and get acks, and I would like to reduce the paperwork involved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was going to be:

Customers who are using the kernel-rt and run either {product-title} 4.6 or 4.7.0 will experience a severe impact.

My point is that both folks running 4.6 and 4.7 are already impacted, so this bug has nothing to do with upgrades to 4.7. It might have something to do with updates from 4.5 to 4.6, but that's irrelevant for the 4.7-and-later release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wking didn't have a chance to review during the initial iteration and had some important changes. Sorry about the inconvenience.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking Above change has been made.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@wking
Copy link
Member

wking commented Mar 10, 2021

Is there someone whose ack we should have taken before publishing it that we didn't?

Not me personally, but the updates team (which should be more similar to @openshift/openshift-team-cincinnati , I'll run down the difference) would like to review statements about OCP update recommendations. Because if an update is really not recommended, we want to stop recommending that update edge. We want to minimize divergence between human-oriented docs and the Cincinnati API that represents OCP update recommendations.

@wking
Copy link
Member

wking commented Mar 24, 2021

Anything we can do to help this along?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 22, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Aug 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants