Skip to content

Removing note that is no longer applicable #30005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 1 commit into from
Mar 3, 2021
Merged

Removing note that is no longer applicable #30005

bergerhoffer merged 1 commit into from
Mar 3, 2021

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 2, 2021 •
edited
Loading

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.7 branch/enterprise-4.8 labels Mar 2, 2021
@bergerhoffer bergerhoffer added this to the Next Release milestone Mar 2, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2021
@netlify
Copy link

netlify bot commented Mar 2, 2021

Deploy preview for osdocs ready!

Built with commit 7613ff9

https://deploy-preview-30005--osdocs.netlify.app

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 2, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Mar 2, 2021

LGTM!

@marun
Copy link

marun commented Mar 2, 2021

LGTM

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 2, 2021

@xingxingxia Can you review the removal of this note for 4.7+? Thanks!

Preview: https://deploy-preview-30005--osdocs.netlify.app/openshift-enterprise/latest/authentication/bound-service-account-tokens.html

@xingxingxia
Copy link
Contributor

xingxingxia commented Mar 3, 2021

LGTM

@bergerhoffer bergerhoffer merged commit d09d1ed into openshift:master Mar 3, 2021
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 3, 2021

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Mar 3, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 3, 2021

@bergerhoffer: new pull request created: #30056

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 3, 2021

@bergerhoffer: new pull request created: #30057

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2021
Merged
@bergerhoffer bergerhoffer deleted the removing-bound-sa-token-note branch August 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@bergerhoffer @bmcelvee @marun @xingxingxia @openshift-cherrypick-robot @openshift-ci-robot