Skip to content

Conversation

@JStickler
Copy link
Contributor

This PR -

  • Adds two new topics to the Custom Resources assembly
    ** Performance and Scalability
    ** Recommended Resources
  • Adds a note in the next steps of Installation assembly that the default settings are for a resource limited environment and should be changed.
  • Adds a line in the Customizing the Installation assembly that the Jaeger defaults must be modified.
  • Adds notes about separation of namespaces to the Deploying Applications assembly. (OSSMDOC-222)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2021
@JStickler JStickler added branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 service-mesh Label for all Service Mesh PRs and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2021
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2021
@netlify
Copy link

netlify bot commented Mar 2, 2021

Deploy preview for osdocs ready!

Built with commit 6f87049dafea71006515982724970f491ea0e4e8

https://deploy-preview-29981--osdocs.netlify.app

@JStickler
Copy link
Contributor Author

@longmuir FYI

@netlify
Copy link

netlify bot commented Mar 2, 2021

Deploy preview for osdocs ready!

Built with commit a87438c

https://deploy-preview-29981--osdocs.netlify.app

@JStickler JStickler requested a review from neal-timpe March 11, 2021 21:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that these two items fit in the custom resources assembly. I think they might be better in a new assembly more focused on performance and tuning.

But if they are to stay in this assembly, I think they're backwards. The recommended resources module recommends changes but doesn't provide a lot of context about what those changes are or do, but some of that information is introduced in the performance and scalability module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neal Timpe agree with your comments about the new content for recommended resources should go with a new assembly on performance and tuning. I was thinking it should go with the High Availability content, once we finally write that. But we'd discussed putting this content into this assembly until we write those other topics. Are you working on performance and scalability with OSSMDOC-246? Do you want me to just merge these modules and you can add them to your assembly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JStickler I'm not sure. We may have discussed it, but now that I see the content, I don't think this is the right place for it.

I'm not writing performance and scalability content in 246. The way I see it, it's more production configuration. I think it relates to this work you're doing with performance and scalability, but I think it would be okay to put it in its own assembly and add HA to it.

It also might be a question for @heathjoy about where we should put this content while we build other content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new assembly for the two new topics. Let me know what you think.

Copy link
Contributor

@neal-timpe neal-timpe Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes more sense. I think it needs to be added to topicmap.yml, but aside from that, it seems like the right thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Added to topic map.

@JStickler JStickler force-pushed the OSSMDOC-223 branch 3 times, most recently from 57b8dad to ed5bfbd Compare March 16, 2021 18:15
@JStickler JStickler changed the title OSSMDOC-223 Document resource guidlines for OSSM Components. OSSMDOC-223 Document resource guidelines for OSSM Components. Mar 17, 2021
@neal-timpe neal-timpe merged commit bdfce1b into openshift:master Mar 17, 2021
@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #30607

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #30612

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #30613

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler JStickler deleted the OSSMDOC-223 branch July 28, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants