-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSSMDOC-223 Document resource guidelines for OSSM Components. #29981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit 6f87049dafea71006515982724970f491ea0e4e8 |
|
@longmuir FYI |
|
Deploy preview for osdocs ready! Built with commit a87438c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that these two items fit in the custom resources assembly. I think they might be better in a new assembly more focused on performance and tuning.
But if they are to stay in this assembly, I think they're backwards. The recommended resources module recommends changes but doesn't provide a lot of context about what those changes are or do, but some of that information is introduced in the performance and scalability module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neal Timpe agree with your comments about the new content for recommended resources should go with a new assembly on performance and tuning. I was thinking it should go with the High Availability content, once we finally write that. But we'd discussed putting this content into this assembly until we write those other topics. Are you working on performance and scalability with OSSMDOC-246? Do you want me to just merge these modules and you can add them to your assembly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler I'm not sure. We may have discussed it, but now that I see the content, I don't think this is the right place for it.
I'm not writing performance and scalability content in 246. The way I see it, it's more production configuration. I think it relates to this work you're doing with performance and scalability, but I think it would be okay to put it in its own assembly and add HA to it.
It also might be a question for @heathjoy about where we should put this content while we build other content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new assembly for the two new topics. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes more sense. I think it needs to be added to topicmap.yml, but aside from that, it seems like the right thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! Added to topic map.
57b8dad to
ed5bfbd
Compare
|
/cherry-pick enterprise-4.6 |
|
@neal-timpe: new pull request created: #30607 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.7 |
|
@neal-timpe: new pull request created: #30612 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.8 |
|
@neal-timpe: new pull request created: #30613 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR -
** Performance and Scalability
** Recommended Resources