-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Bug 1835001: added a note about viewing ChargeBack report if namespace … #29819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit 157aaff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chargeback is the old name for Metering so the line should be updated to:
the Metering reports are only ....
timflannagan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
You'll likely want to retitle this PR in the form of Bug 1835001: ... so automation picks these changes up and adds a link to this PR + moves the state of the BZ for you.
|
@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@timflannagan thanks for your review. Do you or @EmilyM1 have any insight into whether or not this change should also go into 4.6, 4.7, and 4.8 as well? I'm thinking yes, since I see the Metering Operator is still supported in doc but want to confirm: https://docs.openshift.com/container-platform/4.7/metering/metering-installing-metering.html |
|
@skrthomas Yeah backporting to 4.6 sounds reasonable to me. |
|
@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Ready for QE @pruan-rht |
|
@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pruan-rht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Closing this PR since its pulled against the wrong branch and moving changes to #30599 |
added a note about viewing ChargeBack report if namespace is other than
openshift-meteringhttps://bugzilla.redhat.com/show_bug.cgi?id=1835001
This update is for for 4.5 and 4.6.
Direct link to doc preview: https://deploy-preview-29819--osdocs.netlify.app/openshift-enterprise/latest/metering/metering-installing-metering.html#metering-install-operator_installing-metering
Incorporated SME comments from @EmilyM1.