Skip to content

Conversation

@skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Feb 24, 2021

added a note about viewing ChargeBack report if namespace is other than openshift-metering

https://bugzilla.redhat.com/show_bug.cgi?id=1835001

This update is for for 4.5 and 4.6.

Direct link to doc preview: https://deploy-preview-29819--osdocs.netlify.app/openshift-enterprise/latest/metering/metering-installing-metering.html#metering-install-operator_installing-metering

Incorporated SME comments from @EmilyM1.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2021
@netlify
Copy link

netlify bot commented Feb 24, 2021

Deploy preview for osdocs ready!

Built with commit 157aaff

https://deploy-preview-29819--osdocs.netlify.app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chargeback is the old name for Metering so the line should be updated to:
the Metering reports are only ....

Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

You'll likely want to retitle this PR in the form of Bug 1835001: ... so automation picks these changes up and adds a link to this PR + moves the state of the BZ for you.

@skrthomas skrthomas changed the title BZ1835001: added a note about viewing ChargeBack report if namespace … Bug 1835001: added a note about viewing ChargeBack report if namespace … Mar 16, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Mar 16, 2021
@openshift-ci-robot
Copy link

@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1835001 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1835001: added a note about viewing ChargeBack report if namespace …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 16, 2021
@skrthomas
Copy link
Contributor Author

@timflannagan thanks for your review. Do you or @EmilyM1 have any insight into whether or not this change should also go into 4.6, 4.7, and 4.8 as well? I'm thinking yes, since I see the Metering Operator is still supported in doc but want to confirm: https://docs.openshift.com/container-platform/4.7/metering/metering-installing-metering.html

@timflannagan
Copy link
Contributor

@skrthomas Yeah backporting to 4.6 sounds reasonable to me.

@openshift-ci-robot
Copy link

@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1835001 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1835001: added a note about viewing ChargeBack report if namespace …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas
Copy link
Contributor Author

Ready for QE @pruan-rht

@openshift-ci-robot
Copy link

@skrthomas: This pull request references Bugzilla bug 1835001, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1835001 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1835001: added a note about viewing ChargeBack report if namespace …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@pruan-rht pruan-rht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skrthomas
Copy link
Contributor Author

Closing this PR since its pulled against the wrong branch and moving changes to #30599

@skrthomas skrthomas closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants