Skip to content

Add Known Issue for Ingress Canary route edge termination #29807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmcelvee merged 1 commit into from
Mar 2, 2021
Merged

Add Known Issue for Ingress Canary route edge termination #29807

bmcelvee merged 1 commit into from
Mar 2, 2021

Conversation

@bmcelvee
Copy link
Contributor

@bmcelvee bmcelvee commented Feb 24, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2021
@netlify
Copy link

netlify bot commented Feb 24, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 9ac04fe

https://deploy-preview-29807--osdocs.netlify.app

@bmcelvee bmcelvee force-pushed the ingress-canary-kn-rn branch from 6d1ec37 to 31f7984 Compare February 24, 2021 21:17
@bmcelvee
Copy link
Contributor Author

bmcelvee commented Feb 24, 2021

@sgreene570 here's the RN PR!

@sgreene570
Copy link

sgreene570 commented Feb 24, 2021

I double checked my patch command and it looks good!
Thanks @bmcelvee this looks great.

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Feb 24, 2021

@openshift/team-documentation PTAL, thanks! 🌞

@bmcelvee bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 24, 2021
ahardin-rh
ahardin-rh reviewed Feb 24, 2021
View reviewed changes
ahardin-rh
ahardin-rh reviewed Feb 24, 2021
View reviewed changes
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Feb 24, 2021

@bmcelvee Just some minor style suggestions from me 👍

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 24, 2021
@bmcelvee bmcelvee force-pushed the ingress-canary-kn-rn branch from 31f7984 to 9ac04fe Compare February 24, 2021 22:13
@bmcelvee
Copy link
Contributor Author

bmcelvee commented Feb 24, 2021

@lihongan would you mind reviewing this release note, please? Thank you!

@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 24, 2021

lgtm - docs ack.

@lihongan
Copy link

lihongan commented Feb 25, 2021

It looks great!
Thank you @bmcelvee

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Feb 25, 2021

@sferich888 since this is going through our change control process, would you mind reviewing and giving this PR an ack? Please and thank you!

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Mar 1, 2021

@sferich888 since this is going through our change control process, would you mind reviewing and giving this PR an ack? Please and thank you! (Just a bump since this went out right before a long weekend 😸)

@sferich888
Copy link
Contributor

sferich888 commented Mar 2, 2021

@bmcelvee Ack

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Mar 2, 2021

Thank you!

@bmcelvee bmcelvee added this to the Next Release milestone Mar 2, 2021
@bmcelvee bmcelvee merged commit fc0f181 into openshift:enterprise-4.7 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

Assignees

No one assigned

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bmcelvee @sgreene570 @ahardin-rh @vikram-redhat @lihongan @sferich888 @openshift-ci-robot