Skip to content

Notes for pipeline run and task failures in side panel and PLR details page #29687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pneedle-rh merged 1 commit into from
Mar 3, 2021
Merged

Notes for pipeline run and task failures in side panel and PLR details page #29687

pneedle-rh merged 1 commit into from
Mar 3, 2021

Conversation

@Srivaralakshmi
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi commented Feb 23, 2021 •
edited
Loading

Aligned team: DevTools
JIRA ID: RHDEVDOCS-2078
This PR is for OCP 4.6.
This has been reviewed by the SME and QE.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2021
@netlify
Copy link

netlify bot commented Feb 23, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 70f1bda

https://deploy-preview-29687--osdocs.netlify.app

@Srivaralakshmi Srivaralakshmi changed the title Update Pipelines procedures with Notes for the Working with pipelines using the Developer perspective module in CICD Notes for pipeline run and task failures in side panel and PLR details page Feb 24, 2021
@Srivaralakshmi Srivaralakshmi changed the title Notes for pipeline run and task failures in side panel and PLR details page [WIP] Notes for pipeline run and task failures in side panel and PLR details page Feb 24, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Feb 24, 2021 •
edited
Loading

@sanketpathak and @karthikjeeyar: Dear reviewers, I need your help specifically on the object reference for the actual instances in the content flow specifically for words like pipeline, pipeline run, task, task run .. as per these guidelines: https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#api-object-formatting
I know that pipeline run and task run will come as instances and pipeline as object, but I am not sure whether tasks are object or resources.. want to be technically accurate .. so seeking confirmation.

Preeticp
Preeticp reviewed Feb 24, 2021
View reviewed changes
rishumehra
rishumehra reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rishumehra rishumehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2021
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Feb 24, 2021

@karthikjeeyar I have done my best in incorporating the guidelines for the actual instances of the object references. But as I am new and not a geek, I am equally nervous. I will appreciate a review on these edits in the PR from you. Thanks!

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2021
karthikjeeyar
karthikjeeyar reviewed Feb 25, 2021
View reviewed changes
sanketpathak
sanketpathak reviewed Feb 25, 2021
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2021
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Feb 25, 2021 •
edited
Loading

@sanketpathak and @karthikjeeyar Please review and provide LGTM if there are no further comments. Thanks!

@karthikjeeyar
Copy link

karthikjeeyar commented Feb 25, 2021

Thanks @Srivaralakshmi
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@sanketpathak
Copy link

sanketpathak commented Feb 25, 2021

/lgtm

@pneedle-rh pneedle-rh self-requested a review March 1, 2021 09:07
pneedle-rh
pneedle-rh reviewed Mar 1, 2021
View reviewed changes
Copy link
Contributor

@pneedle-rh pneedle-rh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Srivaralakshmi thank you for submitting this PR! I have completed my review. Please let me know if you have any questions about my suggestions.

Please squash all of the commits into one.

Please also confirm if this content is intended only for enterprise-4.6 as per the PR description, or if it should also be cherry picked to enterprise-4.7 and enterprise-4.8.

Thanks!

@pneedle-rh pneedle-rh added branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR labels Mar 1, 2021
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Mar 2, 2021

@pneedle-rh Thanks for the comments, sure.. will do. The content should be cherry picked to enterprise-4.6, enterprise-4.7, and enterprise-4.8.

@pneedle-rh
Copy link
Contributor

pneedle-rh commented Mar 2, 2021

@pneedle-rh Thanks for the comments, sure.. will do. The content should be cherry picked to enterprise-4.6, enterprise-4.7, and enterprise-4.8.

@Srivaralakshmi thank you for confirming that. I have updated the labels in this PR to include the other releases.

Please let me know when you have resolved the suggestions and are ready for the content to be merged.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2021

New changes are detected. LGTM label has been removed.

@Srivaralakshmi Srivaralakshmi changed the title [WIP] Notes for pipeline run and task failures in side panel and PLR details page Notes for pipeline run and task failures in side panel and PLR details page Mar 2, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Mar 2, 2021

@pneedle-rh Hi Paul, as discussed, I have made all the changes. Please merge if the content looks good to you. The content should be cherry picked to enterprise-4.6, enterprise-4.7, and enterprise-4.8.

Thanks!

pneedle-rh
pneedle-rh reviewed Mar 3, 2021
View reviewed changes
@pneedle-rh
Copy link
Contributor

pneedle-rh commented Mar 3, 2021

LGTM

@pneedle-rh pneedle-rh merged commit ea64589 into openshift:master Mar 3, 2021
@pneedle-rh
Copy link
Contributor

pneedle-rh commented Mar 3, 2021

/cherrypick enterprise-4.6

@pneedle-rh
Copy link
Contributor

pneedle-rh commented Mar 3, 2021

/cherrypick enterprise-4.7

@pneedle-rh
Copy link
Contributor

pneedle-rh commented Mar 3, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 3, 2021

@pneedle-rh: #29687 failed to apply on top of branch "enterprise-4.6":

Applying: Notes for pipeline run and task failures in side panel and PLR details page
Using index info to reconstruct a base tree...
M	modules/op-constructing-pipelines-using-pipeline-builder.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/op-constructing-pipelines-using-pipeline-builder.adoc
CONFLICT (content): Merge conflict in modules/op-constructing-pipelines-using-pipeline-builder.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Notes for pipeline run and task failures in side panel and PLR details page
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 3, 2021

@pneedle-rh: new pull request created: #30054

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 3, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 3, 2021

@pneedle-rh: new pull request created: #30055

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Srivaralakshmi Srivaralakshmi mentioned this pull request Mar 3, 2021
Merged
@Srivaralakshmi Srivaralakshmi deleted the pipelines branch March 15, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

+4 more reviewers

@rishumehra rishumehra rishumehra left review comments

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@sanketpathak sanketpathak sanketpathak left review comments

@pneedle-rh pneedle-rh pneedle-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@karthikjeeyar karthikjeeyar

@sanketpathak sanketpathak

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Srivaralakshmi @karthikjeeyar @sanketpathak @pneedle-rh @openshift-ci-robot @openshift-cherrypick-robot @rishumehra @Preeticp