Skip to content

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Feb 22, 2021

@codyhoag codyhoag added this to the Future Release milestone Feb 22, 2021
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2021
@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for osdocs ready!

Built with commit 8d4b7db

https://deploy-preview-29677--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2021
@codyhoag
Copy link
Contributor Author

@jeana-redhat @vikram-redhat Let me know if you see anything egregious I missed. I did light wordsmithing in a few obvious areas, and now have this passing CI. I'll merge once you've acked so I10n can begin. Thanks!

Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to read bug fixes now, here's what I found prior to that

Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did Node Tuning Operator through Performance Addon Operator

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more minor things

Updated notes from Lisa.
@vikram-redhat vikram-redhat merged commit cfc6567 into openshift:enterprise-4.7 Feb 23, 2021
@vikram-redhat
Copy link
Contributor

Thank you @codyhoag and @jeana-redhat for your spectacular effort.

And thank you @bergerhoffer @bobfuru and @lpettyjo for the last minute reviews. Much appreciated.

@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants