Skip to content

Conversation

@codyhoag
Copy link
Contributor

@netlify
Copy link

netlify bot commented Feb 17, 2021

Deploy preview for osdocs ready!

Built with commit 9b86d88

https://deploy-preview-29562--osdocs.netlify.app

@codyhoag
Copy link
Contributor Author

This has an exception to merge as soon as the proper acks are given.

Copy link
Contributor

@vikram-redhat vikram-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for merging after peer review.

@codyhoag codyhoag added branch/enterprise-4.8 peer-review-needed Signifies that the peer review team needs to review this PR and removed branch/enterprise-4.4 labels Feb 24, 2021
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a missing period, otherwise LGTM!

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 24, 2021
Copy link

@dzhaoredhat dzhaoredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this docs addition for the OpenShift Upgrade Graph Labs application looks good to me!

@codyhoag codyhoag merged commit 5ee53c9 into openshift:master Feb 25, 2021
@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@codyhoag: new pull request created: #29856

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@codyhoag: new pull request created: #29857

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: new pull request created: #29858

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@codyhoag: new pull request created: #29859

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants