-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CCO-20:TP docs for AWS STS #29545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCO-20:TP docs for AWS STS #29545
Conversation
|
Deploy preview for osdocs ready! Built with commit 0a4f3f2 |
jeana-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotations to help with review.
authentication/managing_cloud_provider_credentials/about-cloud-credential-operator.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-manual.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-mint.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-passthrough.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
|
Note: Build failure expected until #28974 is merged |
authentication/managing_cloud_provider_credentials/about-cloud-credential-operator.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/about-cloud-credential-operator.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
f50cddc to
2a071ce
Compare
authentication/managing_cloud_provider_credentials/about-cloud-credential-operator.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
2a071ce to
3537bf4
Compare
3537bf4 to
40cb490
Compare
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
@lwan-wanglin you are truly incredible! Just to check - are you all set with this PR? |
c17bd89 to
99f71ee
Compare
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
|
Other contents look good to me. and the feature works well in my test. |
Fixed those updates, thank you very much! |
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
2fb5648 to
a59873f
Compare
|
Final revisions: Joel's updates, and removed preflight tool path per meeting this afternoon. @joelddiaz please take what I sincerely hope is a final look at this :) Preview build here: https://deploy-preview-29545--osdocs.netlify.app/openshift-enterprise/latest/authentication/managing_cloud_provider_credentials/cco-mode-sts.html#sts-mode-installing |
a59873f to
455298f
Compare
joelddiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one tiny less-than sign :)
authentication/managing_cloud_provider_credentials/cco-mode-sts.adoc
Outdated
Show resolved
Hide resolved
455298f to
0a4f3f2
Compare
|
/cherrypick enterprise-4.7 |
|
@jeana-redhat: new pull request created: #29672 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For https://issues.redhat.com/browse/OSDOCS-1735
Main goal of PR is to add STS content. However, this also necessitated a re-organization of the CCO content into subdirectories, so it now lives in the Auth book.
Previews
Forgot to add here: There are a couple of topics at the end of post-config cluster tasks and the mint mode overview that will not load until #28974 is merged.
Some feedback is out of scope for this effort, but should be addressed. Tracking in OSDOCS-1817.