Skip to content

Conversation

@jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Feb 16, 2021

For https://issues.redhat.com/browse/OSDOCS-1735

Main goal of PR is to add STS content. However, this also necessitated a re-organization of the CCO content into subdirectories, so it now lives in the Auth book.

Previews

Forgot to add here: There are a couple of topics at the end of post-config cluster tasks and the mint mode overview that will not load until #28974 is merged.

Some feedback is out of scope for this effort, but should be addressed. Tracking in OSDOCS-1817.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 16, 2021
@jeana-redhat jeana-redhat changed the title CCO-20:TP docs for AWS STS [WIP] CCO-20:TP docs for AWS STS Feb 16, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2021
@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for osdocs ready!

Built with commit 0a4f3f2

https://deploy-preview-29545--osdocs.netlify.app

Copy link
Contributor Author

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations to help with review.

@jeana-redhat
Copy link
Contributor Author

Note: Build failure expected until #28974 is merged

@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from f50cddc to 2a071ce Compare February 17, 2021 20:15
@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from 2a071ce to 3537bf4 Compare February 18, 2021 16:41
@jeana-redhat jeana-redhat changed the title [WIP] CCO-20:TP docs for AWS STS CCO-20:TP docs for AWS STS Feb 18, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2021
@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from 3537bf4 to 40cb490 Compare February 18, 2021 16:56
@jeana-redhat jeana-redhat added this to the Future Release milestone Feb 18, 2021
@jeana-redhat
Copy link
Contributor Author

yes, I can use these manually steps to successfully install .

@lwan-wanglin you are truly incredible! Just to check - are you all set with this PR?

@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from c17bd89 to 99f71ee Compare February 19, 2021 15:44
@lwan-wanglin
Copy link

Other contents look good to me. and the feature works well in my test.

@jeana-redhat
Copy link
Contributor Author

Other contents look good to me. and the feature works well in my test.

Fixed those updates, thank you very much!

@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch 8 times, most recently from 2fb5648 to a59873f Compare February 22, 2021 20:48
@jeana-redhat
Copy link
Contributor Author

Final revisions: Joel's updates, and removed preflight tool path per meeting this afternoon. @joelddiaz please take what I sincerely hope is a final look at this :) Preview build here: https://deploy-preview-29545--osdocs.netlify.app/openshift-enterprise/latest/authentication/managing_cloud_provider_credentials/cco-mode-sts.html#sts-mode-installing

@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from a59873f to 455298f Compare February 22, 2021 20:54
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny less-than sign :)

@jeana-redhat jeana-redhat force-pushed the CCO-20_tech_preview_aws_sts_day-zero_support branch from 455298f to 0a4f3f2 Compare February 22, 2021 22:11
@jeana-redhat jeana-redhat merged commit 9c23607 into openshift:master Feb 22, 2021
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #29672

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat jeana-redhat deleted the CCO-20_tech_preview_aws_sts_day-zero_support branch July 16, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants