Skip to content

Conversation

@mburke5678
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2021
@netlify
Copy link

netlify bot commented Feb 10, 2021

Deploy preview for osdocs ready!

Built with commit 715d784

https://deploy-preview-29416--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2021
@mburke5678
Copy link
Contributor Author

@sunilcio PTAL. Thanks!!

@sunilcio
Copy link

@mburke5678 thanks, lgtm

@mburke5678
Copy link
Contributor Author

@umohnani8 Which OpenShift versions does this change apply to? It looks like the code change went into 4.6. Was it back ported to 4.5 or 4.4? Thank you!

@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 23, 2021
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The minimum memory limit for a depoyment is 12 MB. If a container fails to start due to a `Cannot allocate memory` pod event, the memory limit is too low. You should either increase or remove the memory limit. Removing the limit allows pods to consume unbounded node resources.
The minimum memory limit for a deployment is 12 MB. If a container fails to start due to a `Cannot allocate memory` pod event, the memory limit is too low. Either increase or remove the memory limit. Removing the limit allows pods to consume unbounded node resources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You should either increase or remove the memory limit. Removing the limit allows pods to consume unbounded node resources.
Either increase or remove the memory limit. Removing the limit allows pods to consume unbounded node resources.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 23, 2021
@kalexand-rh kalexand-rh added this to the Next Release milestone Feb 23, 2021
@umohnani8
Copy link

@mburke5678 this change should be available in 4.4 and 4.5 as well. The cri-o PR made it in before cri-o 1.15 was cut.

@mburke5678 mburke5678 merged commit 3d2b921 into openshift:master Feb 24, 2021
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29820

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.6

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.7

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29821

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29822

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29823

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants