Skip to content

Conversation

@rishumehra
Copy link
Contributor

[RHDEVDOCS-2332] - Documentation of using the Developer Catalog

For Openshift 4.7

JIRA task: https://issues.redhat.com/browse/RHDEVDOCS-2332

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for osdocs ready!

Built with commit 73eb34d

https://deploy-preview-29275--osdocs.netlify.app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Developer Catalog...
Suggest: The Developer Catalog contains a collection of application components, services, event sources, or source-to-image builders that you can add to your project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Will incorporate this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then click on MariaDB ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the application group containing the Node.Js component;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, edited the sentence as suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/app.kubernetes.io/part-of=myapp/app.kubernetes.io/part-of=<application-name>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change the application name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...you can also add a component in the Topology view to an application...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

@rishumehra rishumehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Preeticp Thanks for your comments and review. Will make the changes and push a new commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, edited the sentence as suggested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change the application name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Will incorporate this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rishumehra
Copy link
Contributor Author

@Preeticp pushed a new commit with the changes based on your earlier suggestions. Kindly have a look.

@Preeticp
Copy link
Contributor

Preeticp commented Feb 9, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@Preeticp Preeticp removed their assignment Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. In the *Developer* perspective, navigate to the *+Add* view and select the *Database* option to see the *Developer Catalog*, which has multiple options that you can add as components or services to your application.
.. In the *Developer* perspective, navigate to the *+Add* page and select the *Database* option to see the *Developer Catalog*, which has multiple options that you can add as components or services to your application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user clicks on Database card on +Add page, it will open the Developer Catalog page with Database options. In above sentence, it seems that you have added description of Developer Catalog page instead it should what user will see when he/she clicks on Database card on Add page. WDYT about updating above sentence? @Preeticp @rishumehra

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajanan-more the change from view to page, if done needs to be uniform across the OCP doc set. If required we will pick that change up through another PR.
Suggest similar wording as we have in the other module:
. In the Developer perspective, navigate to the +Add page and select the Database option to view all the available services in the Developer Catalog.
. Select Databases to list all the database services, and then click on the MariaDB option to see the details for the service.
Does this make it more clear?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 1:
. In the Developer perspective, navigate to the +Add page and select the From Catalog option to view all the available services in the Developer Catalog.
. Select Databases to list all the database services, and then click on the MariaDB option to see the details for the service.

Option 2:
. In the Developer perspective, navigate to the +Add page and select the Database option to view all the available database services present in the Developer Catalog under Database.
. Select MariaDB option to see the details for the service.

WDYT @Preeticp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajanan-more option 1 seems perfect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 1 seems fine to me also. Will incorporate that in the new commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User will automatically redirected to Topology page and doesn't need to click anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I drop this bullet point or rephrase it with the automatic redirection.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will drop in this in the new commit.

Copy link
Contributor Author

@rishumehra rishumehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajanan-more @Preeticp Checked all the comments and replied to them also. Will make the changes in the new commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 1 seems fine to me also. Will incorporate that in the new commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I drop this bullet point or rephrase it with the automatic redirection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will drop in this in the new commit.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
Copy link

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Create and deploy the MariaDB service to your project as follows:
. Create and deploy the MariaDB service to your project:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. In the *Developer* perspective, navigate to the *+Add* view and select the *From Catalog* option to view all of the available services in the *Developer Catalog*.
.. In the *Developer* perspective, navigate to the *+Add* view and select the *From Catalog* option to view all available services in the *Developer Catalog*.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. Select *Databases* to list all the database services, and then click on the *MariaDB* option to see the details for the service.
.. Select *Databases* to list all the database services and then click *MariaDB* option to see the details for the service.

🚫 click on verb
Do not use. Use "click" instead to refer to the action of selecting something on a graphical interface.

Please be consistent about using or not using the comma between your clauses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sequence doesn't follow the guidance in the IBM Style Guide for keyboard shortcuts. I think that

Suggested change
. To add the MariaDB service to the existing application group, kbd:[Shift]+ dragging the *mariadb* pod to the application group containing the Node.Js component; the MariaDB service is added to the existing application group.
. To add the MariaDB service to the existing application group, press kbd:[Shift]+ and drag the *mariadb* pod to the application group that contains the Node.Js component. The MariaDB service is added to the existing application group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Click on the MariaDB service node to see the label `app.kubernetes.io/part-of=<application-name>` added to the *Labels* section in the *Overview* Panel. kbd:[Shift]+ dragging a component and adding it to an application group automatically adds the required labels to the component.
. Click the MariaDB service node and confirm that the `app.kubernetes.io/part-of=<application-name>`label is in the *Labels* section in the *Overview* Panel. Adding a component to an application group automatically adds the required labels to the component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Procedure
To add a *MariaDB* database service from the Developer Catalog:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following procedure shows you an example of how to add a *MariaDB* database service from the Developer Catalog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. In the *Developer* perspective, navigate to the *+Add -> From Catalog* to view all the available services in the *Developer Catalog*.
. In the *Developer* perspective, navigate to the *+Add* -> *From Catalog* to view all the available services in the *Developer Catalog*.

Each menu item needs to be enclosed in asterisks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Under *All Items* select the kind of service or the component you need to add to your project. For this example, select *Databases* to list all the database services and then click on *MariaDB* to see the details for the service.
. Under *All Items*, select the kind of service or the component you need to add to your project. For this example, select *Databases* to list all the database services and then click *MariaDB* to see the details for the service.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need either of these screenshots. They don't add significant value and require maintenance.

@kalexand-rh kalexand-rh added branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 10, 2021
@kalexand-rh kalexand-rh added this to the Future Release milestone Feb 10, 2021
@kalexand-rh kalexand-rh merged commit 9c6a78b into openshift:master Feb 10, 2021
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #29388

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Feb 10, 2021
@openshift-cherrypick-robot

@kalexand-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#openshift-cherrypick-robot:cherry-pick-29275-to-enterprise-4.7 from enterprise-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.7 and openshift-cherrypick-robot:cherry-pick-29275-to-enterprise-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants