Skip to content

Update OSDK scorecard for 4.7 #29274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adellape merged 1 commit into from
Feb 10, 2021
Merged

Update OSDK scorecard for 4.7 #29274

adellape merged 1 commit into from
Feb 10, 2021

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Feb 9, 2021 •
edited
Loading

@adellape adellape added this to the Future Release milestone Feb 9, 2021
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2021
@adellape adellape mentioned this pull request Feb 9, 2021
Closed
@adellape adellape force-pushed the scorecard_47 branch 8 times, most recently from ce0444b to 9fd417e Compare February 9, 2021 20:34
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2021
@adellape adellape changed the title [WIP] Update OSDK scorecard for 4.7 Update OSDK scorecard for 4.7 Feb 9, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 9, 2021
@openshift openshift deleted a comment from netlify bot Feb 9, 2021
@adellape
Copy link
Contributor Author

adellape commented Feb 9, 2021

@kuiwang02 You had previously reviewed #26315 for alpha scorecard in OCP 4.6, but we ended up not documenting it then. Would you be able to review this updated scorecard doc for OSDK v1.3.0 in 4.7 GA? Or @emmajiafan are you able? Thank you.

theishshah
theishshah approved these changes Feb 9, 2021
View reviewed changes
Copy link

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
ahardin-rh
ahardin-rh reviewed Feb 9, 2021
View reviewed changes
@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 9, 2021
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Feb 9, 2021

@adellape Just one suggestion from me! 👍

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2021

New changes are detected. LGTM label has been removed.

@emmajiafan
Copy link

emmajiafan commented Feb 10, 2021

@cuipinghuo Please help review this doc. Thank you!

@adellape adellape merged commit b9dc05c into openshift:master Feb 10, 2021
@adellape adellape deleted the scorecard_47 branch February 10, 2021 04:53
@adellape
Copy link
Contributor Author

adellape commented Feb 10, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 10, 2021

@adellape: new pull request created: #29344

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

+1 more reviewer

@theishshah theishshah theishshah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@theishshah theishshah

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.7 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@adellape @ahardin-rh @openshift-ci-robot @emmajiafan @openshift-cherrypick-robot @theishshah @vikram-redhat