-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ocprhv-66 RHV - CSI driver provisioning [enterprise-4.7] #29269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit f2b4ad5 |
jboxman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I went through this, but it needs quite a few revisions, so I stopped.
If you can make the suggested changes, I can take another look. It's not possible to merge this as is. It's quite divergent from the style we normally use in customer facing content.
Thanks!
jboxman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update; I've reviewed the PR and left some additional comments for your review.
storage/container_storage_interface/persistent-storage-csi-ovirt.adoc
Outdated
Show resolved
Hide resolved
storage/container_storage_interface/persistent-storage-csi-ovirt.adoc
Outdated
Show resolved
Hide resolved
|
@emarcusRH, you also need to rebase your branch and squash your commits. |
|
@emarcusRH, I can't merge this until you rebase. |
|
/cherrypick enterprise-4.7 |
|
@kalexand-rh: new pull request created: #30053 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.8 |
|
@kalexand-rh: new pull request created: #30058 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[Enterprise-4.7] https://issues.redhat.com/browse/OCPBUGSM-23181
[Enterprise-4.7] https://bugzilla.redhat.com/show_bug.cgi?id=1916486
RHV CSI provisioning - new sections for "oVirt CSI driver storage class" and "Creating a persistent volume on RHV"