Skip to content

Conversation

@emarcusRH
Copy link
Contributor

@emarcusRH emarcusRH commented Feb 8, 2021

[Enterprise-4.7] https://issues.redhat.com/browse/OCPBUGSM-23181

[Enterprise-4.7] https://bugzilla.redhat.com/show_bug.cgi?id=1916486
RHV CSI provisioning - new sections for "oVirt CSI driver storage class" and "Creating a persistent volume on RHV"

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2021
@emarcusRH emarcusRH changed the title ocprhv-66 initial draft of storage options ovirt CSI WIP: ocprhv-66 initial draft of storage options ovirt CSI Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for osdocs ready!

Built with commit f2b4ad5

https://deploy-preview-29269--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2021
@emarcusRH emarcusRH changed the title WIP: ocprhv-66 initial draft of storage options ovirt CSI ocprhv-66 new section describing RHV - ovirt CSI driver provisioning Feb 16, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2021
@emarcusRH emarcusRH changed the title ocprhv-66 new section describing RHV - ovirt CSI driver provisioning ocprhv-66 new section describing RHV - ovirt CSI driver provisioning [enterprise-4.7] Feb 16, 2021
@jboxman jboxman added this to the Future Release milestone Feb 16, 2021
Copy link
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I went through this, but it needs quite a few revisions, so I stopped.

If you can make the suggested changes, I can take another look. It's not possible to merge this as is. It's quite divergent from the style we normally use in customer facing content.

Thanks!

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
Copy link
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update; I've reviewed the PR and left some additional comments for your review.

@kalexand-rh
Copy link
Contributor

@emarcusRH, you also need to rebase your branch and squash your commits.

@emarcusRH emarcusRH changed the title ocprhv-66 new section describing RHV - ovirt CSI driver provisioning [enterprise-4.7] ocprhv-66 RHV - ovirt CSI driver provisioning [enterprise-4.7] Mar 1, 2021
@emarcusRH emarcusRH changed the title ocprhv-66 RHV - ovirt CSI driver provisioning [enterprise-4.7] ocprhv-66 RHV - CSI driver provisioning [enterprise-4.7] Mar 1, 2021
@kalexand-rh
Copy link
Contributor

@emarcusRH, I can't merge this until you rebase.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2021
@kalexand-rh kalexand-rh merged commit 10b6cb6 into openshift:master Mar 3, 2021
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30053

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30058

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.8 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants