Skip to content

Conversation

@sjstout
Copy link

@sjstout sjstout commented Feb 8, 2021

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for osdocs ready!

Built with commit 24032bf

https://deploy-preview-29263--osdocs.netlify.app

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way closer than the number of comments implies. :) The xrefs all need to include anchor IDs, and the table headings need to also use sentence case. We also use bare "OpenShift" as little as possible, so I've added a few {product-title}s.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the sections below to find content that will help you learn about and use {product-title}.
Use the following sections to find content to help you learn about and use {product-title}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Learn about OpenShift |Plan an OpenShift Deployment |Additional Resources
| Learn about {product-title} |Plan an {product-title} deployment |Additional resources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| link:https://www.openshift.com/blog?hsLang=en-us[Openshift blogs]
| link:https://www.openshift.com/blog?hsLang=en-us[OpenShift blog]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Learn about OpenShift |Deploy OpenShift |Manage OpenShift |Additional Resources
|Learn about OpenShift |Deploy OpenShift |Manage OpenShift |Additional resources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| xref:../installing/installing-preparing.adoc[Installing {product-title}]
| xref:../installing/installing-preparing.adoc#installing-preparing[Installing {product-title}]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| xref:../builds/understanding-image-builds.adoc[Builds]
| xref:../builds/understanding-image-builds.adoc#understanding-image-builds[Builds]

@kalexand-rh kalexand-rh added branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 9, 2021
@kalexand-rh kalexand-rh changed the title Launch page osdocs-1713 - new launch page Feb 10, 2021
@kalexand-rh kalexand-rh merged commit d4733dd into openshift:master Feb 10, 2021
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #29374

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants