Skip to content

Conversation

@jritter
Copy link
Contributor

@jritter jritter commented Jan 27, 2021

Configuring the ServiceMeshControlPlane object according to the documentation does not work, the documentation specifies incorrect keys.

Fixes https://issues.redhat.com/browse/OSSMDOC-224

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2021
@netlify
Copy link

netlify bot commented Jan 27, 2021

Deploy preview for osdocs ready!

Built with commit 20d4303

https://deploy-preview-28904--osdocs.netlify.app

@JStickler
Copy link
Contributor

@rcernich, could you please review this configuration? I think we probably need to update this entire topic for SMCP2.0, not just this code example.

@knrc
Copy link

knrc commented Mar 1, 2021

@JStickler Since this documentation is for SMCP 1.1 the values are correct as they stand. The real issue is that @jritter tried to use them on SMCP 2.0 which would obviously not work so I think your comment about updating this for 2.0 is the correct solution.

Copy link

@knrc knrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be merged as this stands, this needs to augment the existing 1.1 content with 2.0 content rather than replace it.

@JStickler JStickler added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2021
@JStickler JStickler added branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 service-mesh Label for all Service Mesh PRs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 17, 2021
@JStickler JStickler requested a review from neal-timpe March 17, 2021 14:24
@JStickler JStickler merged commit b319d07 into openshift:master Mar 17, 2021
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@JStickler: new pull request created: #30583

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@JStickler: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-28904-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-28904-to-enterprise-4.6."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@JStickler: new pull request created: #30585

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #30587

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants