-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Egress Router CNI (OSDOCS-979) #28778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egress Router CNI (OSDOCS-979) #28778
Conversation
mikemckiernan
commented
Jan 22, 2021
- The ER CNI plug-in is TP for the 4.7 release.
|
Draft /hold |
|
@jboxman , @danielmellado , @weliang1 , PTAL. If this is technically accurate and the definition of concision, then I'll take an approval or thumbs up now and add a URL to the content after #28609 is merged. |
|
/lgtm |
|
Hi @mikemckiernan , left a few comments also on #28609, sounds good to me! I'll also reply to your JIRA and try to get a slot for a quick meeting on Fri! Thanks! |
|
New changes are detected. LGTM label has been removed. |
|
Deploy preview for osdocs ready! Built with commit 566c398 |
|
@openshift/team-documention, PTAL. After Daniel's review, I rebased and added an xref to the new topic. /hold cancel Applies to enterprise-4.7 and--small guess--milestone Future-Release. Please add the label, milestone, and merge if it looks OK. |
adellape
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple tiny things. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/The plug-in enables you to/You can use the plug-in to/
(Per IBMSG)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/and this/, and this/
* The ER CNI plug-in is TP for the 4.7 release. * Peer review from Alex.
|
@adellape , thank you for the review and corrections. It's ready for merge when you get a chance. |