Skip to content

Conversation

@mikemckiernan
Copy link

  • The ER CNI plug-in is TP for the 4.7 release.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@mikemckiernan
Copy link
Author

Draft

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2021
@mikemckiernan
Copy link
Author

mikemckiernan commented Jan 27, 2021

@jboxman , @danielmellado , @weliang1 , PTAL.

If this is technically accurate and the definition of concision, then I'll take an approval or thumbs up now and add a URL to the content after #28609 is merged.

@danielmellado
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
@danielmellado
Copy link

Hi @mikemckiernan , left a few comments also on #28609, sounds good to me! I'll also reply to your JIRA and try to get a slot for a quick meeting on Fri! Thanks!

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for osdocs ready!

Built with commit 566c398

https://deploy-preview-28778--osdocs.netlify.app

@mikemckiernan
Copy link
Author

mikemckiernan commented Feb 8, 2021

@openshift/team-documention, PTAL. After Daniel's review, I rebased and added an xref to the new topic.

/hold cancel

Applies to enterprise-4.7 and--small guess--milestone Future-Release.

Please add the label, milestone, and merge if it looks OK.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple tiny things. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/The plug-in enables you to/You can use the plug-in to/

(Per IBMSG)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/and this/, and this/

@adellape adellape added branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 8, 2021
@adellape adellape added this to the Future Release milestone Feb 8, 2021
* The ER CNI plug-in is TP for the 4.7 release.
* Peer review from Alex.
@mikemckiernan
Copy link
Author

@adellape , thank you for the review and corrections. It's ready for merge when you get a chance.

@adellape adellape merged commit d89c6da into openshift:enterprise-4.7 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants