Image Registry update for Z and Power #28642

ktania46 · 2021-01-18T13:19:25Z

BZ : https://bugzilla.redhat.com/show_bug.cgi?id=1894382

This update is for 4.5 , 4.6 and 4.7 release

openshift-docs-preview-bot · 2021-01-18T13:22:39Z

The preview will be available shortly at:

modules/olm-pruning-index-image.adoc: https://crw--ocpdocs.netlify.com/openshift-enterprise/latest/modules/olm-pruning-index-image.html

ghatwala · 2021-01-18T13:30:06Z

Had confirmed using this flag - --binary-image or -i to prune the source index of all but the specified packages via steps given here - https://bugzilla.redhat.com/show_bug.cgi?id=1894382#c4

ghatwala · 2021-01-27T15:21:25Z

LGTM

SNiemann15 · 2021-01-27T15:26:21Z

@doris.xu Can you validate this on Z please?

nickboldt · 2021-01-27T15:57:10Z

modules/olm-pruning-index-image.adoc

    -f {index-image-pullspec} \// <1>
    -p {package1},{package2},{package3} \// <2>
    -t <target_registry>:<port>/<namespace>/{index-image} <3>
+    -i registry.redhat.io/openshift4/ose-operator-registry/{index-image} 


should there be a <4> on this line and an explanation below? Also if this is only needed for P & Z, what's the default -i value for amd64?

If that line isn't needed for other architectures I would suggest we remove the note and make it a callout.

<4> Use -i only with IBM Power Systems and IBM Z images.

The default value of base image is quay.io/operator-framework/upstream-opm-builder which isn't multi-arch and thus prune command - opm index prune fails on Power ( should fail on Z too , yet to be validated though) . To resolve this had to replace it with - registry.redhat.io/openshift4/ose-operator-registry which is multi-arch passed using flag -i to prune command .... fyi @SNiemann15 @nickboldt

So... leave it in with the default?

-i quay.io/operator-framework/upstream-opm-builder <4>

then below...

ghatwala · 2021-02-02T05:24:27Z

FYI [email protected]

netlify · 2021-02-10T12:44:48Z

Deploy preview for osdocs ready!

Built with commit ab707dd

https://deploy-preview-28642--osdocs.netlify.app

tdaleibm · 2021-02-10T13:22:34Z

/lgtm

openshift-ci-robot · 2021-02-10T13:22:45Z

@tdaleibm: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ghatwala · 2021-02-10T14:46:29Z

/lgtm

openshift-ci-robot · 2021-02-10T14:46:40Z

@ghatwala: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nickboldt · 2021-02-10T16:03:38Z

modules/olm-pruning-index-image.adoc

So then:

<4> For IBM Power Systems and IBM Z images, a different image must be used: -i registry.redhat.io/openshift4/ose-operator-registry/{index-image}

?

Will it be mentioned somewhere else what {index-image} to actuallly use? I believe we can explicitly say to use -i registry.redhat.io/openshift4/ose-operator-registry:v4.6 for both P and Z.

kalexand-rh · 2021-02-10T13:37:39Z

modules/olm-pruning-index-image.adoc

Suggested change

-i registry.redhat.io/openshift4/ose-operator-registry/{index-image}

-i registry.redhat.io/openshift4/ose-operator-registry/{index-image} <4>

@ktania46 Remember also to put a trailing \ at the end of previous lines when you're adding a new final line to these sort of multi-line commands. For example:

-t <target_registry>:<port>/<namespace>/{index-image} \// <3> -i registry.redhat.io/openshift4/ose-operator-registry/{index-image} <4>

(Note that \// is required when the line also includes a callout like <3>.)

I'm fixing this spot in another related PR, so just FYI for the future. Thank you for the PR! 🎉

kalexand-rh · 2021-02-10T13:38:48Z

modules/olm-pruning-index-image.adoc

Suggested change

<4> Use `-i` only with IBM Power Systems and IBM Z images.

<4> Use the `-i` option with only IBM Power Systems and IBM Z images.

Is this option optional or required for IBM Z/Power? If it's optional, it's fine, but if a Z/Power needs to use this option, please clarify.

This is required for IBM Z/Power.

vikram-redhat · 2021-02-17T09:09:03Z

hold for merge till after 4.7 GA at which point it should be Cherrypicked to 4.8 branch as well.

codyhoag · 2021-02-25T15:34:28Z

/cherrypick enterprise-4.8

codyhoag · 2021-02-25T15:34:47Z

/cherrypick enterprise-4.7

codyhoag · 2021-02-25T15:34:52Z

/cherrypick enterprise-4.6

codyhoag · 2021-02-25T15:35:05Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2021-02-25T15:35:06Z

@codyhoag: #28642 failed to apply on top of branch "enterprise-4.8":

Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-02-25T15:35:28Z

@codyhoag: new pull request created: #29846

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-02-25T15:35:32Z

@codyhoag: new pull request created: #29847

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-02-25T15:35:43Z

@codyhoag: #28642 failed to apply on top of branch "enterprise-4.5":

Applying: CRW Image Registry update for Z and Power
Using index info to reconstruct a base tree...
A	modules/olm-pruning-index-image.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/olm-pruning-index-image.adoc deleted in HEAD and modified in CRW Image Registry update for Z and Power. Version CRW Image Registry update for Z and Power of modules/olm-pruning-index-image.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 CRW Image Registry update for Z and Power
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codyhoag · 2021-02-25T16:57:53Z

@ktania46 the edited file in this PR did not exist for enterprise-4.5, so the changes were not cherry-picked there. Please follow up with another PR for 4.5 specifically if there's something that needs to be added there. Thanks!

jianzhangbjz · 2021-03-29T02:40:03Z

@codyhoag As you may know, this PR leads to a bug https://bugzilla.redhat.com/show_bug.cgi?id=1943150 reported by the customer. So, could you help ask the QE have a review before merging it in the future? Thanks! cc: @adellape
You can reach out to us in the #forum-qe channel of Slack. Like:

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2021

ktania46 changed the title ~~CRW Image Registry update for Z and Power~~ Image Registry update for Z and Power Jan 18, 2021

nickboldt reviewed Jan 27, 2021

View reviewed changes

kalexand-rh added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 labels Feb 10, 2021

nickboldt reviewed Feb 10, 2021

View reviewed changes

kalexand-rh reviewed Feb 10, 2021

View reviewed changes

ktania46 requested review from aburdenthehand, codyhoag, jeana-redhat and vikram-redhat as code owners February 11, 2021 06:22

CRW Image Registry update for Z and Power

ab707dd

codyhoag added the branch/enterprise-4.8 label Feb 25, 2021

codyhoag merged commit 384e4f5 into openshift:master Feb 25, 2021

openshift-cherrypick-robot mentioned this pull request Feb 25, 2021

[enterprise-4.7] Image Registry update for Z and Power #29846

Merged

openshift-cherrypick-robot mentioned this pull request Feb 25, 2021

[enterprise-4.6] Image Registry update for Z and Power #29847

Merged

codyhoag added this to the Next Release milestone Feb 25, 2021

codyhoag mentioned this pull request Feb 25, 2021

[enterprise-4.8] CRW Image Registry update for Z and Power #29860

Merged

	-i registry.redhat.io/openshift4/ose-operator-registry/{index-image}
	-i registry.redhat.io/openshift4/ose-operator-registry/{index-image} <4>

	<4> Use `-i` only with IBM Power Systems and IBM Z images.
	<4> Use the `-i` option with only IBM Power Systems and IBM Z images.

Image Registry update for Z and Power #28642

Image Registry update for Z and Power #28642

Uh oh!

Conversation

ktania46 commented Jan 18, 2021

Uh oh!

openshift-docs-preview-bot commented Jan 18, 2021

Uh oh!

ghatwala commented Jan 18, 2021

Uh oh!

ghatwala commented Jan 27, 2021

Uh oh!

SNiemann15 commented Jan 27, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghatwala commented Feb 2, 2021

Uh oh!

netlify bot commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tdaleibm commented Feb 10, 2021

Uh oh!

openshift-ci-robot commented Feb 10, 2021

Uh oh!

ghatwala commented Feb 10, 2021

Uh oh!

openshift-ci-robot commented Feb 10, 2021

Uh oh!

nickboldt Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vikram-redhat commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codyhoag commented Feb 25, 2021

Uh oh!

codyhoag commented Feb 25, 2021

Uh oh!

codyhoag commented Feb 25, 2021

Uh oh!

codyhoag commented Feb 25, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 25, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 25, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 25, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 25, 2021

Uh oh!

codyhoag commented Feb 25, 2021

Uh oh!

jianzhangbjz commented Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

netlify bot commented Feb 10, 2021 •

edited

Loading

nickboldt Feb 10, 2021 •

edited

Loading

vikram-redhat commented Feb 17, 2021 •

edited

Loading