Skip to content

Conversation

@danielmellado
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2021
@knobunc knobunc requested a review from jboxman January 13, 2021 15:37
@jboxman jboxman self-assigned this Jan 13, 2021
@jboxman jboxman added this to the Future Release milestone Jan 13, 2021
@jboxman
Copy link
Contributor

jboxman commented Jan 13, 2021

@danielmellado, thanks! I'll try to look through this by the end of next week. Ultimately I'll probably need to restructure this into several different modules.

And is it likely that in the future it will include support for all of the egress router types in OpenShift SDN? If so, I'll need to try to plan for that future work as well.

@jboxman
Copy link
Contributor

jboxman commented Jan 13, 2021

Hi @danielmellado,

@mikemckiernan has joined me on the docs team working on SDN-related content; He'll be working through this PR with you.

Thanks!

@jboxman
Copy link
Contributor

jboxman commented Jan 15, 2021

@mikemckiernan, also NetworkAttachmentDefinition is what Multiple networks is based on. Unfortunately I never expanded upon what that means, and a generic overview is somewhat of a blindspot I'd like to address someday. But that doesn't really impact this PR specifically.

@mikemckiernan
Copy link

@danielmellado , I copied your commit to my fork. I plan to take credit for your great ideas.

I've initiated a follow up PR with the required wordsmithing and structural reorganization.

@jboxman, can you remove the branch label from this PR please? And maybe add it to mine? The absence of git superpowers sometimes has its benefits.

@jboxman jboxman removed this from the Future Release milestone Jan 15, 2021
@jboxman jboxman closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants