-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPRHV-416 new chap - Cluster setup on RHV in a restricted network #28522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit 6cee979 |
6b2876b to
9ca51cc
Compare
9ca51cc to
3a02688
Compare
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see another IPI restricted network guide go in! I've provided some feedback. I think there are a few merge conflict issues that may have overwritten some existing content. Let me know if you have any questions.
This will need to be verified by QE as well (didn't see any acks on the PR).
installing/installing_rhv/installing-rhv-restricted-network.adoc
Outdated
Show resolved
Hide resolved
installing/installing_rhv/installing-rhv-restricted-network.adoc
Outdated
Show resolved
Hide resolved
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the followup work. This is getting close. I've provided some additional feedback on the remaining issues. I also pointed out what I believe is causing the build issues.
installing/installing_rhv/installing-rhv-restricted-network.adoc
Outdated
Show resolved
Hide resolved
9f1741f to
ef567bd
Compare
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emarcusRH This is so close! Just a few last things to wrap up.
Can you also mark the RHV IPI restricted network cell in the support matrix here: https://docs.openshift.com/container-platform/4.7/installing/installing-preparing.html#supported-installation-methods-for-different-platforms?
installing/installing_rhv/installing-rhv-restricted-network.adoc
Outdated
Show resolved
Hide resolved
|
Confirmed with Eli that this has passed QE review. |
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
@codyhoag: #28522 failed to apply on top of branch "enterprise-4.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@codyhoag: #28522 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…p on RHV in restricted network
Installing a cluster on RHV in a restricted network [enterprise-4.7]
https://issues.redhat.com/browse/OCPRHV-416