Skip to content

CNV-7058 Autofill Flavour and Workload #28514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aburdenthehand merged 1 commit into from
Feb 10, 2021
Merged

CNV-7058 Autofill Flavour and Workload #28514

aburdenthehand merged 1 commit into from
Feb 10, 2021

Conversation

@aburdenthehand
Copy link
Contributor

@aburdenthehand aburdenthehand commented Jan 12, 2021 •
edited by openshift-ci-robot
Loading

Added line to Operating System in the VM wizard table explaining that selecting OS pre-fills Flavor and Workload with defaults.

CNV-7058

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2021
@aburdenthehand aburdenthehand added branch/enterprise-4.7 CNV Label for all CNV PRs and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2021
@aburdenthehand aburdenthehand added this to the Future Release milestone Jan 12, 2021
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Jan 12, 2021

The preview will be available shortly at:

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2021
@jelkosz
Copy link

jelkosz commented Jan 18, 2021

lgtm

@gouyang
Copy link

gouyang commented Jan 25, 2021

This is more about common template, Create VM needs to select a template and it uses the template's OS/Flavor/Workload Type. Note: OS is not able to change in wizard.

@aburdenthehand aburdenthehand force-pushed the cnv-7058-default-size-flavor branch from 9ae0a47 to 723e7b7 Compare February 8, 2021 11:58
@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for osdocs ready!

Built with commit 723e7b7

https://deploy-preview-28514--osdocs.netlify.app

@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 8, 2021

@gouyang Thank you.
I've conditionalised that cell so that it is different for VMs and VM templates:
Preview for virtual machines
Preview for VM templates

@gouyang
Copy link

gouyang commented Feb 10, 2021

LGTM

@ousleyp
Copy link
Member

ousleyp commented Feb 10, 2021

LGTM, I am just mildly tripped up by the word "primary." I don't even know if it's a nit; it just makes me go "is there a secondary operating system?" :)

@aburdenthehand aburdenthehand merged commit 3f82a64 into openshift:master Feb 10, 2021
@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 10, 2021

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 10, 2021

@aburdenthehand: new pull request created: #29368

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand aburdenthehand deleted the cnv-7058-default-size-flavor branch July 12, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.7 CNV Label for all CNV PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.7 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@aburdenthehand @openshift-docs-preview-bot @jelkosz @gouyang @ousleyp @openshift-cherrypick-robot @vikram-redhat @openshift-ci-robot