Skip to content

BZ1827131 - Update LSO wording #26720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobfuru merged 1 commit into from
Oct 27, 2020
Merged

BZ1827131 - Update LSO wording #26720

bobfuru merged 1 commit into from
Oct 27, 2020

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Oct 26, 2020

Minor formatting updates to LSO doc as described in BZ1827131.

@bobfuru bobfuru added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 labels Oct 26, 2020
@bobfuru bobfuru added this to the Next Release milestone Oct 26, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 26, 2020

The preview will be available shortly at:

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 26, 2020

@openshift/team-documentation PTAL

jeana-redhat
jeana-redhat reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an odd styling aberration, otherwise LGTM. LMK if you need approval when you get the style thing figured out :)

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 26, 2020
jeana-redhat
jeana-redhat approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting fixed now 👍

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 26, 2020

Thanks, @Jeana, for pointing out the --- issue!

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 26, 2020

@qinpingli PTAL for QE ack.

@qinpingli
Copy link

qinpingli commented Oct 27, 2020

@chao007 Please help take a look, thx!

@chao007
Copy link

chao007 commented Oct 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@bobfuru bobfuru merged commit 22e8173 into openshift:master Oct 27, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.4

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #26791

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #26792

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #26793

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru deleted the BZ1827131 branch October 27, 2020 14:35
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #26794

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees

@chao007 chao007

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bobfuru @openshift-docs-preview-bot @qinpingli @chao007 @openshift-cherrypick-robot @jeana-redhat @openshift-ci-robot